Bug 84168

Summary: change writerperfect filters to use a new base class template
Product: LibreOffice Reporter: David Tardon <dtardon>
Component: filters and storageAssignee: Not Assigned <libreoffice-bugs>
Status: NEW --- QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard: EasyHack DifficultyBeginner SkillCpp TopicCleanup
i915 platform: i915 features:

Description David Tardon 2014-09-22 07:46:21 UTC
Most of the import filter services in writerperfect are derived from a base class called ImportFilterBase, that implements boilerplate code common for all the filters. However, there are separate implementations of ImportFilterBase in every submodule, i.e., writerperfect/source/draw, writerperfect/source/writer (there used to be one in writerperfect/source/calc too). To avoid duplication, this class has been generalized to a template writerperfect::ImportFilter (writerperfect/inc/writerperfect/ImportFilter.hxx). The goal is to replace use of writerperfect::*::ImportFilterBase by writerperfect::ImportFilter.

Commit https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=a23a51af899b31bcf93781637371ffd8ef813bf5 shows a sample conversion of the filters in writerperfect/source/calc.
Comment 1 David Tardon 2014-10-22 11:01:46 UTC
writerperfect/source/impress should be adapted too

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.