Bug 84258

Summary:	Impress and Draw sharing code causing problems with icons and menus
Product:	LibreOffice	Reporter:	Jay Philips <philipz85>
Component:	Libreoffice	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	medium	CC:	f.alexander.wilms, kendy, s.mehrbrodt
Version:	Inherited From OOo
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	84909

Description Jay Philips 2014-09-23 21:51:21 UTC

As Impress and Draw share the same code base, they both utilize uno commands like .uno:InsertPage and .uno:DeletePage which have the same icon in both apps, which is a problem as the default icon looks like a page and in impress it should look like a slide.

This problem also happens in menus and context menus as Draw has Insert > Slide (bug 84208) and Impress has Format > Page (bug 84257).

Comment 1 Samuel Mehrbrodt 2014-09-23 21:55:16 UTC

The add/delete icons have been changed to look like slides with this commit: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=d6aaff5d56c3273595218e7fba803c52e3ba9c46

This needs to be revisited (Draw needs page icons).

Comment 2 Jay Philips 2014-11-14 09:49:59 UTC

The uno commands that need duplication are these

.uno:InsertPage
.uno:DuplicatePage
.uno:DeletePage
.uno:PageSetup
.uno:RenamePage

so the new ones should be named like InsertSlide.

Comment 3 Jay Philips 2014-11-23 08:01:23 UTC

There is also a problem with the statusbar as it uses 'Slide 1 / 1' in Draw rather than Page.

Comment 4 Jay Philips 2014-12-22 14:39:22 UTC

Another problem is that the dialog that appears from .uno:RenamePage is titled 'Rename Slide' and the name is set to 'Slide 1' and these dont work for Draw.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.