Bug 84268

Update case list:
igt/kms_cursor_crc/cursor-128x42-offscreen
igt/kms_cursor_crc/cursor-128x42-onscreen
igt/kms_cursor_crc/cursor-128x42-random
igt/kms_cursor_crc/cursor-128x42-sliding
igt/kms_cursor_crc/cursor-256x85-offscreen
igt/kms_cursor_crc/cursor-256x85-onscreen
igt/kms_cursor_crc/cursor-256x85-random
igt/kms_cursor_crc/cursor-256x85-sliding
igt/kms_cursor_crc/cursor-64x21-offscreen
igt/kms_cursor_crc/cursor-64x21-onscreen
igt/kms_cursor_crc/cursor-64x21-random
igt/kms_cursor_crc/cursor-64x21-sliding

About another cases, here have another bug 84269 to track.

Arent these 2 duplicate of: https://bugs.freedesktop.org/show_bug.cgi?id=83640 ?

I mean, did you tried that bisected point?

(In reply to comment #2)
> Arent these 2 duplicate of:
> https://bugs.freedesktop.org/show_bug.cgi?id=83640 ?
> 
> I mean, did you tried that bisected point?

The bisect result about bug 83640 is invalid. The bug 83640 always exist. which duplicate with bug 81377.

About cases list in this bug we didn't test them before. They should be new cases.

I can't really reproduce this "Invalid argument" error, only the igt_crc_equal() assertion (which is bug 72864). Does this bug still happen for you on drm-intel-nightly?

(In reply to Paulo Zanoni from comment #4)
> I can't really reproduce this "Invalid argument" error, only the
> igt_crc_equal() assertion (which is bug 72864). Does this bug still happen
> for you on drm-intel-nightly?

The failure still able to reproduce on latest -nightly(ead7d71357628dc1231535886ec09853e9164d6d)

root@x-bdw05:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_cursor_crc --run-subtest cursor-128x42-offscreen
IGT-Version: 1.8-gb7d80d1 (x86_64) (Linux: 3.17.0_drm-intel-nightly_ead7d7_20141013+ x86_64)
Beginning cursor-128x42-offscreen on pipe A, connector eDP-1
.Test assertion failure function igt_cursor_commit_legacy, file igt_kms.c:1333:
Failed assertion: ret == 0
Last errno: 22, Invalid argument
Subtest cursor-128x42-offscreen: FAIL (0.136s)

Ok, I rechecked and indeed I can reproduce the bug.

This patch fixes the problem for me: http://patchwork.freedesktop.org/patch/35067/

(In reply to Paulo Zanoni from comment #6)
> Ok, I rechecked and indeed I can reproduce the bug.
> 
> This patch fixes the problem for me:
> http://patchwork.freedesktop.org/patch/35067/

Patch committed to IGT. Closing bug.

When verifying, please make sure your IGT contains the patch.

(In reply to Paulo Zanoni from comment #7)
> (In reply to Paulo Zanoni from comment #6)
> > Ok, I rechecked and indeed I can reproduce the bug.
> > 
> > This patch fixes the problem for me:
> > http://patchwork.freedesktop.org/patch/35067/
> 
> Patch committed to IGT. Closing bug.
> 
> When verifying, please make sure your IGT contains the patch.

Test skips on latest igt

root@x-bdw05:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_cursor_crc --run-subtest cursor-128x42-offscreen
IGT-Version: 1.8-gbba1cd0 (x86_64) (Linux: 3.18.0-rc1_drm-intel-nightly_f2bcbc_20141021+ x86_64)
Test requirement not met in function run_test_generic, file kms_cursor_crc.c:466:
Test requirement: has_nonsquare_cursors(data->devid)
Subtest cursor-128x42-offscreen: SKIP (0.000s)


commit bba1cd0091b3e8e987f15dac1f38d233b5b0ee78
Author:     Paulo Zanoni <paulo.r.zanoni@intel.com>
AuthorDate: Tue Oct 14 13:52:58 2014 -0300
Commit:     Paulo Zanoni <paulo.r.zanoni@intel.com>
CommitDate: Fri Oct 17 19:00:50 2014 -0300

    tests/kms_cursor_crc: HSW/BDW only have square cursors

    When I look at cursor_size_ok() (from the Kernel's intel_display.c), I
    see that only 845g and i865g support non-square cursors, so SKIP the
    tests on HSW/BDW instead of failing them.

    This problem happened because support for non-square cursors was being
    developed for HSW/BDW, but it ended up not being merged due to a small
    problem and priority changes. Let's make those tests SKIP until we
    have proper support on the Kernel: after that, we can revert this
    patch.

    v2: Improve commit message.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84268
    Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Closing old verified.