Bug 84541

Summary: driver can fail to compile when config.h is used
Product: xorg Reporter: Brian Lloyd <brian.lloyd>
Component: Driver/geodeAssignee: X.org Geode Mailing List <xorg-driver-geode>
Status: RESOLVED FIXED QA Contact: X.org Geode Mailing List <xorg-driver-geode>
Severity: normal    
Priority: medium    
Version: 7.7 (2012.06)   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
adds standard config.h include to top of file none

Description Brian Lloyd 2014-10-01 06:50:06 UTC 
Created attachment 107165 [details]
adds standard config.h include to top of file

The src/lx_memory.c file uses the xf86.h header file.  This file must have HAVE_STRNDUP defined before calling it when the building platform has a strndup function.  When using config.h, this file doesn't have that define and so fails to compile.

The attached patch adds the conditional config.h to this file so it may compile on the affected platforms.

The patch is trivial and may be included and used under whatever licensing desired.

Signed-off-by: Brian A. Lloyd <brian.lloyd@familyhonor.net>
Comment 1 Martin-Éric Racine 2014-10-01 09:39:56 UTC 
Thanks for this patch. 

Merged in upstream Git repository. 

Should be included in the upcoming xf86-video-geode 2.11.17 release.
Comment 2 Martin-Éric Racine 2014-10-04 20:36:49 UTC 
PS: on exactly what platform does this happen?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.