Bug 84750

Summary: [igt] intel-gpu-tools/configure.ac dumper test breaks in non-bash shells
Product: DRI Reporter: Adam Sampson <ats-fd>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: minor    
Priority: low CC: intel-gfx-bugs, przanoni, thomas.wood
Version: XOrg git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Change == to = none

Description Adam Sampson 2014-10-07 13:38:28 UTC 
Created attachment 107494 [details] [review]
Change == to =

In intel-gpu-tools 1.8, the configure.ac tests to enable the register dumper contain the following at line 140:

if test "x$DUMPER" == xyes; then

It ought to be "=" (like a few lines earlier), not "==". The latter works in bash but not in other shells; the configure script breaks if (for example) /bin/sh is dash. Patch attached that just removes one of the =s.
Comment 1 Paulo Zanoni 2014-10-07 13:51:52 UTC 
Hi

If you have the time for that and think it could be fun, you could try to write this patch against the latest intel-gpu-tools tree (http://cgit.freedesktop.org/xorg/app/intel-gpu-tools), commit using "git commit", then use git-format-patch and git-send-email to send the patch to intel-gfx @ lists.freedesktop.org :)

Otherwise, we can do it ourselves.

Thanks for the patch!
Comment 2 Adam Sampson 2014-10-07 16:45:00 UTC 
Patch sent, along with a second bashism that I spotted ("+=" further down).
Comment 3 Paulo Zanoni 2014-10-09 12:08:47 UTC 
Patches were merged into IGT. Closing bug. If you think there's still a problem, freel free to reopen the bug.

Thanks,
Paulo

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.