| Summary: | creating single page ps from huge pdf slow / function "PSConverter::convert()" ignores page ranges | ||
|---|---|---|---|
| Product: | poppler | Reporter: | t_d_l_c |
| Component: | qt4 frontend | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | t_d_l_c |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Proposed Patch
The cc-File before and after the patch New patch with new constructor for PsOutputDev patch for poppler-0.24.5 My patch to implement non consecutive pspages |
||
|
Description
t_d_l_c
2014-10-09 09:07:41 UTC
Created attachment 107610 [details] [review] Proposed Patch Here is my proposed patch. Can anyone say if my patch might have some side effects? Is it possible that one page influences the rendering of another page? I iterate over the page list to determine the min/max page. Would it be more appropriate to simply use the first and last element of the page list? Can I rely on that? Created attachment 107611 [details]
The cc-File before and after the patch
The cc-File before and after the patch, along with the same patch as in the other attachment
Best solution would be actually adding a new constructor to PsOutputDev that accepts a list, do you think you can work on that? Created attachment 108287 [details] [review] New patch with new constructor for PsOutputDev An external company has fixed it for us. This should be used as the top patch in the ubuntu paket in version 0.18.4-1ubuntu3.1. I have not tested this patch yet and will provide a patch for 0.24.5 shortly. Created attachment 108296 [details] [review] patch for poppler-0.24.5 I got the patch for poppler-0.24.5 now and attach it to this bug. It was made for our version of the ubuntu-packet poppler_0.24.5-0ubuntu3. Please feel free to contact me if it does not work with the upstream version. We are highly interested that this bug is fixed in the upstream version of poppler (and okular). I tested the poppler-0.24.5 patch and it works for us. Question: Who should get the copyright attribution for this patch? t_d_l_c ping I can't decide on the copyright myself, sorry. My Boss will provide feedback concerning the copyright. Most probable is "Landeshaupstadt München/City of Munich", even though the patch was written by credativ GmbH. But please wait until my boss has decided on that. No pressure, but i'm releasing poppler 0.28 today so it'd be awesome if we could get an answer today so i can include the patch ;) even if the (C) is "Landeshaupstadt München/City of Munich" i'll also need an email address to put besides it According to my boss you can take "Landeshaupstadt München/City of Munich" and my official address ludwig.cornelius {at} muenchen.de
Actually i just had a look at the patch and realized i can't use that, it's a huge copy and paste of code. I understand why a contractor would do that but it increases our maintaince costs too much so I can't accept it. I'm doing my own patch that does the same but i'll need to test it so it may not end up on the next release. Created attachment 108708 [details] [review] My patch to implement non consecutive pspages Thanks for fixing it upstream. That's very useful for us. My patch has now been pushed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.