Summary: | Map New Font Family Names for New URW Fonts Release | ||
---|---|---|---|
Product: | fontconfig | Reporter: | Tom Yan <tom.ty89> |
Component: | conf | Assignee: | Akira TAGOH <akira> |
Status: | RESOLVED FIXED | QA Contact: | Behdad Esfahbod <freedesktop> |
Severity: | normal | ||
Priority: | medium | CC: | akira, fontconfig-bugs, ht990332 |
Version: | 2.11 | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=97468 | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
30-metric-aliases
45-latin 60-latin 30-metric-aliases with commit for 73291 reverted as in git 30-metric-aliaes patch 45-latin patch 60-latin patch integrated patch done in full git |
Description
Tom Yan
2014-10-20 09:03:15 UTC
Created attachment 108094 [details]
30-metric-aliases
Created attachment 108095 [details]
45-latin
Created attachment 108096 [details]
60-latin
Created attachment 108100 [details]
30-metric-aliases with commit for 73291 reverted as in git
Please attach the patch instead of the updated files. Created attachment 108151 [details] [review] 30-metric-aliaes patch patch against commit e7121de237a1873c3241a5b8451e7d00a3d41524 Created attachment 108152 [details] [review] 45-latin patch patch against commit e7121de237a1873c3241a5b8451e7d00a3d41524 Created attachment 108153 [details] [review] 60-latin patch patch against commit e7121de237a1873c3241a5b8451e7d00a3d41524 Created attachment 108155 [details] [review] integrated patch done in full git against commit e7121de237a1873c3241a5b8451e7d00a3d41524 Comment on attachment 108155 [details] [review] integrated patch done in full git Review of attachment 108155 [details] [review]: ----------------------------------------------------------------- See the inline comment the below. ::: conf.d/60-latin.conf @@ +10,4 @@ > <family>Thorndale AMT</family> > <family>Luxi Serif</family> > <family>Nimbus Roman No9 L</family> > + <family>Nimbus Roman</family> Is this position expected thing? the order is somewhat important. it is added to the pattern as is. so if both version is installed, old one might be picked up. @@ +24,4 @@ > <family>Albany AMT</family> > <family>Luxi Sans</family> > <family>Nimbus Sans L</family> > + <family>Nimbus Sans</family> Ditto. @@ +42,4 @@ > <family>Cumberland AMT</family> > <family>Luxi Mono</family> > <family>Nimbus Mono L</family> > + <family>Nimbus Mono</family> Ditto. I wonder how much chance would someone want to have both versions installed. Also all the file names remain unchanged upstream. As for the order, perhaps it's more about the attitude of you guys towards the new version. I only know that the new version no longer have cyrillic glyphs and someone might not like that. Not sure if people are simply not aware of the new release or they just stick to it on purpose. Though priority doesn't seem matter to me, I hope that fontconfig can at least support the upstream version. Yet IHMO in the long run everyone should switch to upstream version and the old names should be removed from the fontconfig one day. (In reply to Tom Yan from comment #11) > As for the order, perhaps it's more about the attitude of you guys towards > the new version. I only know that the new version no longer have cyrillic > glyphs and someone might not like that. Not sure if people are simply not > aware of the new release or they just stick to it on purpose. Aha. that's good to hear that there are some regression in the new version. so fair enough to keep the old one as higher priority. though I guess there are many many improvements in new one. > Though priority doesn't seem matter to me, I hope that fontconfig can at > least support the upstream version. > > Yet IHMO in the long run everyone should switch to upstream version and the > old names should be removed from the fontconfig one day. Definitely. but would be really the long-term item in the to-do. Just to add that according to the current maintainer, the Cyrillic glyphs in the old version are very badly design and we shouldn't be using them given to the poor quality. Also Cyrillic glyphs are not required to be present in the PostScript base fonts. Not sure if the there are many improvements, but at least now we can have something to map to for Helvetica Condensed, and no more "L"/"No9" non-sense. :) Okay, merged into git. thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.