Bug 85305

geoclue 2.1.10

Weird, works fine here:

(geoclue:10599): Geoclue-DEBUG: New modem '/org/freedesktop/ModemManager1/Modem/0'
(geoclue:10599): Geoclue-DEBUG: Modem '/org/freedesktop/ModemManager1/Modem/0' has location capabilities
(geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClue3G: 5
(geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClueModemGPS: 8

Which modem is this?

(In reply to Zeeshan Ali from comment #2)
> Weird, works fine here:
> 
> (geoclue:10599): Geoclue-DEBUG: New modem
> '/org/freedesktop/ModemManager1/Modem/0'
> (geoclue:10599): Geoclue-DEBUG: Modem
> '/org/freedesktop/ModemManager1/Modem/0' has location capabilities
> (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClue3G: 5
> (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClueModemGPS:
> 8
> 
> Which modem is this?

Either 1) that modem doesn't have location capabilities (which probably should be logged in the debug output), or 2) it fails to respond because the SIM is locked (?).

(In reply to Bastien Nocera from comment #3)
> (In reply to Zeeshan Ali from comment #2)
> > Weird, works fine here:
> > 
> > (geoclue:10599): Geoclue-DEBUG: New modem
> > '/org/freedesktop/ModemManager1/Modem/0'
> > (geoclue:10599): Geoclue-DEBUG: Modem
> > '/org/freedesktop/ModemManager1/Modem/0' has location capabilities
> > (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClue3G: 5
> > (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClueModemGPS:
> > 8
> > 
> > Which modem is this?
> 
> Either 1) that modem doesn't have location capabilities (which probably
> should be logged in the debug output), or 2) it fails to respond because the
> SIM is locked (?).

I'd be surprised if either is true since Laurent says that everything works fine if he starts geoclue after inserting the modem.

(In reply to Zeeshan Ali from comment #4)
> (In reply to Bastien Nocera from comment #3)
> > (In reply to Zeeshan Ali from comment #2)
> > > Weird, works fine here:
> > > 
> > > (geoclue:10599): Geoclue-DEBUG: New modem
> > > '/org/freedesktop/ModemManager1/Modem/0'
> > > (geoclue:10599): Geoclue-DEBUG: Modem
> > > '/org/freedesktop/ModemManager1/Modem/0' has location capabilities
> > > (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClue3G: 5
> > > (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClueModemGPS:
> > > 8
> > > 
> > > Which modem is this?
> > 
> > Either 1) that modem doesn't have location capabilities (which probably
> > should be logged in the debug output), or 2) it fails to respond because the
> > SIM is locked (?).
> 
> I'd be surprised if either is true since Laurent says that everything works
> fine if he starts geoclue after inserting the modem.

"Inserting the modem", or "inserting the modem and unlocking the SIM card"?

(In reply to Bastien Nocera from comment #5)
> (In reply to Zeeshan Ali from comment #4)
> > (In reply to Bastien Nocera from comment #3)
> > > (In reply to Zeeshan Ali from comment #2)
> > > > Weird, works fine here:
> > > > 
> > > > (geoclue:10599): Geoclue-DEBUG: New modem
> > > > '/org/freedesktop/ModemManager1/Modem/0'
> > > > (geoclue:10599): Geoclue-DEBUG: Modem
> > > > '/org/freedesktop/ModemManager1/Modem/0' has location capabilities
> > > > (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClue3G: 5
> > > > (geoclue:10599): Geoclue-DEBUG: Available accuracy level from GClueModemGPS:
> > > > 8
> > > > 
> > > > Which modem is this?
> > > 
> > > Either 1) that modem doesn't have location capabilities (which probably
> > > should be logged in the debug output), or 2) it fails to respond because the
> > > SIM is locked (?).
> > 
> > I'd be surprised if either is true since Laurent says that everything works
> > fine if he starts geoclue after inserting the modem.
> 
> "Inserting the modem", or "inserting the modem and unlocking the SIM card"?

I guess only Laurent can answer that.

Hello,

According to lsusb, the modem is:
Bus 007 Device 011: ID 12d1:1001 Huawei Technologies Co., Ltd. E169/E620/E800 HSDPA Modem

When I was talking about inserting the modem, it was inserting + SIM unlocking.

Note that in the following scenario I'm using a simcard that is not in service anymore because I'm current active one has not the proper form factor for the modem...

Case 1:

0) Modem unplugged
1) Start Modemmanager
2) Insert the USB modem
3) Modemmanager asks for PIN, I enter PIN
4) Modemmanager: "state changed (enabling -> enabled)" and displays signal strength
5) Start geoclue-2.0:

$ G_MESSAGES_DEBUG=all /usr/lib/geoclue-2.0/geoclue 
(geoclue:30013): Geoclue-DEBUG: Available accuracy level from GClueWifi: 4
(geoclue:30013): Geoclue-DEBUG: New modem '/org/freedesktop/ModemManager1/Modem/0'
(geoclue:30013): Geoclue-DEBUG: Modem '/org/freedesktop/ModemManager1/Modem/0' has location capabilities
(geoclue:30013): Geoclue-DEBUG: Available accuracy level from GClue3G: 5
(geoclue:30013): Geoclue-DEBUG: New agent for user ID '1000'

6) Run where-am-i demo:

(geoclue:30013): Geoclue-DEBUG: Number of connected clients: 1
(geoclue:30013): Geoclue-DEBUG: 'geoclue-where-am-i' not in configuration
(geoclue:30013): Geoclue-DEBUG: requested accuracy level: 8. Accuracy level allowed by agent: 8
(geoclue:30013): Geoclue-DEBUG: GClueLocator now active
(geoclue:30013): Geoclue-DEBUG: GClue3G now active
(geoclue:30013): Geoclue-DEBUG: Not starting GClueCDMA (accuracy level: 0). Requested accuracy level: 8.
(geoclue:30013): Geoclue-DEBUG: GClueWifi now active
(geoclue:30013): Geoclue-DEBUG: Not starting GClueModemGPS (accuracy level: 0). Requested accuracy level: 8.
(geoclue:30013): Geoclue-DEBUG: 'geoclue-where-am-i' started.
(geoclue:30013): Geoclue-DEBUG: manager '/org/freedesktop/ModemManager1/Modem/0' enabled.
(geoclue:30013): Geoclue-DEBUG: Modem '/org/freedesktop/ModemManager1/Modem/0' setup.
(geoclue:30013): Geoclue-DEBUG: No 3GPP
(geoclue:30013): Geoclue-DEBUG: Network available

7) where-am-i displays a location

(geoclue:30013): Geoclue-WARNING **: Failed to create query: 3GPP cell tower info unavailable
(geoclue:30013): Geoclue-DEBUG: Network available
(geoclue:30013): Geoclue-DEBUG: Sending following request to 'https://location.services.mozilla.com/v1/geolocate?key=geoclue':
{}
(geoclue:30013): Geoclue-DEBUG: Got following response from 'https://location.services.mozilla.com/v1/geolocate?key=geoclue':
{"location": {"lat": 50.8333, "lng": 4.3333}, "accuracy": 50000.0}
(geoclue:30013): Geoclue-DEBUG: New location available

8) Now I'm unplugging the USB modem

(geoclue:30013): Geoclue-DEBUG: Modem '/org/freedesktop/ModemManager1/Modem/0' removed.
(geoclue:30013): Geoclue-DEBUG: Available accuracy level from GClue3G: 0

9) Repluging the modem after a few sec
10) modemmanager asks for PIN
11) geoclue displays: "(geoclue:30013): Geoclue-DEBUG: New modem '/org/freedesktop/ModemManager1/Modem/1'"
12) I'm running the where-am-i demo again:

(geoclue:30013): Geoclue-DEBUG: Number of connected clients: 1
(geoclue:30013): Geoclue-DEBUG: 'geoclue-where-am-i' not in configuration
(geoclue:30013): Geoclue-DEBUG: requested accuracy level: 8. Accuracy level allowed by agent: 8
(geoclue:30013): Geoclue-DEBUG: GClueLocator now active
(geoclue:30013): Geoclue-DEBUG: Not starting GClue3G (accuracy level: 0). Requested accuracy level: 8.
(geoclue:30013): Geoclue-DEBUG: Not starting GClueCDMA (accuracy level: 0). Requested accuracy level: 8.
(geoclue:30013): Geoclue-DEBUG: GClueWifi now active
(geoclue:30013): Geoclue-DEBUG: Not starting GClueModemGPS (accuracy level: 0). Requested accuracy level: 8.
(geoclue:30013): Geoclue-DEBUG: 'geoclue-where-am-i' started.

13) where-am-i demo returns no location:

(geoclue:30013): Geoclue-DEBUG: GClueLocator now inactive
(geoclue:30013): Geoclue-DEBUG: GClueWifi now inactive
(geoclue:30013): Geoclue-DEBUG: Requested GClueWifi to stop
(geoclue:30013): Geoclue-DEBUG: Number of connected clients: 0

(In reply to Laurent Bigonville from comment #7)

Thanks for providing so many details! I have one question:

> 9) Repluging the modem after a few sec
> 10) modemmanager asks for PIN

Does this imply that you provide the pin?

(In reply to Zeeshan Ali from comment #8)
> (In reply to Laurent Bigonville from comment #7)
> 
> Thanks for providing so many details! I have one question:
> 
> > 9) Repluging the modem after a few sec
> > 10) modemmanager asks for PIN
> 
> Does this imply that you provide the pin?

Yes. And to be complete:

- (geoclue:8789): Geoclue-DEBUG: New modem '/org/freedesktop/ModemManager1/Modem/1' appears before I even enter the PIN

- I can confirm that ModemManager displays "state changed (enabling -> enabled)"

I could try with another SIM card (provider) which is active, but I'm hit by bug #89482 (In that bug you have the full debug log of ModemManager is you want)

(In reply to Laurent Bigonville from comment #9)
> (In reply to Zeeshan Ali from comment #8)
> > (In reply to Laurent Bigonville from comment #7)
> > 
> > Thanks for providing so many details! I have one question:
> > 
> > > 9) Repluging the modem after a few sec
> > > 10) modemmanager asks for PIN
> > 
> > Does this imply that you provide the pin?
> 
> Yes. And to be complete:
> 
> - (geoclue:8789): Geoclue-DEBUG: New modem
> '/org/freedesktop/ModemManager1/Modem/1' appears before I even enter the PIN
> 
> - I can confirm that ModemManager displays "state changed (enabling ->
> enabled)"

Ok, thanks. I think I now have all the needed info to try to fix this bug. I hope ModemManager already has the API for geoclue to detect and wait for modem to be enabled.

(In reply to Zeeshan Ali from comment #10)
> (In reply to Laurent Bigonville from comment #9)
> > (In reply to Zeeshan Ali from comment #8)
> > > (In reply to Laurent Bigonville from comment #7)
> > > 
> > > Thanks for providing so many details! I have one question:
> > > 
> > > > 9) Repluging the modem after a few sec
> > > > 10) modemmanager asks for PIN
> > > 
> > > Does this imply that you provide the pin?
> > 
> > Yes. And to be complete:
> > 
> > - (geoclue:8789): Geoclue-DEBUG: New modem
> > '/org/freedesktop/ModemManager1/Modem/1' appears before I even enter the PIN
> > 
> > - I can confirm that ModemManager displays "state changed (enabling ->
> > enabled)"
> 
> Ok, thanks. I think I now have all the needed info to try to fix this bug. I
> hope ModemManager already has the API for geoclue to detect and wait for
> modem to be enabled.

You can either watch the StateChanged signal, waiting for a state >= Enabled:
http://www.freedesktop.org/software/ModemManager/api/latest/gdbus-org.freedesktop.ModemManager1.Modem.html#gdbus-signal-org-freedesktop-ModemManager1-Modem.StateChanged

Or otherwise, if you're not interested in the old state, you can just follow changes in the "State" property:
http://www.freedesktop.org/software/ModemManager/api/latest/gdbus-org.freedesktop.ModemManager1.Modem.html#gdbus-property-org-freedesktop-ModemManager1-Modem.State

The location capabilities will only be reported by ModemManager once the Location interface has been exposed. If you're interested just in checking the capabilities, you can also just monitor for the presence of the Location interface. If you just want to check for the existence of that interface one, then you should do it when the Enabled state (or >) is reached; if at that point there is no Location interface, there are no location capabilities.

> If you just want to check for the existence of that interface one
*once

(In reply to Aleksander Morgado from comment #11)
> (In reply to Zeeshan Ali from comment #10)
> > (In reply to Laurent Bigonville from comment #9)
> > > (In reply to Zeeshan Ali from comment #8)
> > > > (In reply to Laurent Bigonville from comment #7)
> > > > 
> > > > Thanks for providing so many details! I have one question:
> > > > 
> > > > > 9) Repluging the modem after a few sec
> > > > > 10) modemmanager asks for PIN
> > > > 
> > > > Does this imply that you provide the pin?
> > > 
> > > Yes. And to be complete:
> > > 
> > > - (geoclue:8789): Geoclue-DEBUG: New modem
> > > '/org/freedesktop/ModemManager1/Modem/1' appears before I even enter the PIN
> > > 
> > > - I can confirm that ModemManager displays "state changed (enabling ->
> > > enabled)"
> > 
> > Ok, thanks. I think I now have all the needed info to try to fix this bug. I
> > hope ModemManager already has the API for geoclue to detect and wait for
> > modem to be enabled.
> 
> You can either watch the StateChanged signal, waiting for a state >= Enabled:
> http://www.freedesktop.org/software/ModemManager/api/latest/gdbus-org.
> freedesktop.ModemManager1.Modem.html#gdbus-signal-org-freedesktop-
> ModemManager1-Modem.StateChanged
> 
> Or otherwise, if you're not interested in the old state, you can just follow
> changes in the "State" property:
> http://www.freedesktop.org/software/ModemManager/api/latest/gdbus-org.
> freedesktop.ModemManager1.Modem.html#gdbus-property-org-freedesktop-
> ModemManager1-Modem.State
> 
> The location capabilities will only be reported by ModemManager once the
> Location interface has been exposed. If you're interested just in checking
> the capabilities, you can also just monitor for the presence of the Location
> interface. If you just want to check for the existence of that interface
> one, then you should do it when the Enabled state (or >) is reached; if at
> that point there is no Location interface, there are no location
> capabilities.

I implemented this yesterday and ended up breaking geoclue even more. (As we discussed on IM) The issue is that geoclue has to enable the modem itself (due to bug#730131) and it only does that when location interface is actually needed. This combined with the fact that geoclue is only interested in one modem (it currently picks up the first one it finds location caps on) makes solving this bug a bit difficult.

(In reply to Zeeshan Ali from comment #13)
>
> I implemented this yesterday and ended up breaking geoclue even more. (As we
> discussed on IM) The issue is that geoclue has to enable the modem itself
> (due to bug#730131)

I quoted a GNOME bug. :) The bug was moved to fdo as bug#85040.

Created attachment 114961 [details] [review]
modem-manager: Don't enable the modem

Seems at least GNOME takes care of modem enabling for us and besides
this shouldn't be done by geoclue anyway (see bug#85040).

Created attachment 114962 [details] [review]
modem-manager: Wait for modem to be enabled

Modem's location capabilities won't be known until its enabled.

Attachment 114961 [details] pushed as fe79da7 - modem-manager: Don't enable the modem
Attachment 114962 [details] pushed as 9206839 - modem-manager: Wait for modem to be enabled