Bug 85906

Summary:	[BSW]igt/kms_setmode sporadically causes ERROR CPU pipe C FIFO underrun
Product:	DRI	Reporter:	lu hua <huax.lu>
Component:	DRM/Intel	Assignee:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Status:	CLOSED FIXED	QA Contact:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity:	normal
Priority:	medium	CC:	christophe.prigent, gary.c.wang, intel-gfx-bugs, ullysses.a.eoff, ville.syrjala, wayne.boyer
Version:	unspecified
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:	BSW/CHT	i915 features:	display/Other

Description lu hua 2014-11-05 08:38:53 UTC

==System Environment==
--------------------------
Regression:  not sure

Non-working platforms: BSW

==kernel==
--------------------------
drm-intel-nightly/f56717bdf29eb7d6a9ec15f095ea2a6858895473

==Bug detailed description==
--------------------------
It sporadically fails on BSW with -nightly kernel, fail rate:3/5.

output:
IGT-Version: 1.8-ge622850 (x86_64) (Linux: 3.18.0-rc3_drm-intel-nightly_f56717_20141105+ x86_64)
Testing: clone-exclusive-crtc 2 connector combinations
  Test id#1 CRTC count 2
    CRTC[8] [Pipe A] Mode: 1920x1080@60Hz Connectors: eDP-1[29]
    CRTC[13] [Pipe B] Mode: 640x480@60Hz Connectors: HDMI-A-1[22] (NC)
  Test id#2 CRTC count 2
    CRTC[13] [Pipe B] Mode: 1920x1080@60Hz Connectors: eDP-1[29]
    CRTC[8] [Pipe A] Mode: 640x480@60Hz Connectors: HDMI-A-1[22] (NC)
  Test id#3 CRTC count 2
    CRTC[8] [Pipe A] Mode: 1920x1080@60Hz Connectors: eDP-1[29]
    CRTC[18] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[35] (NC)
  Test id#4 CRTC count 2
    CRTC[13] [Pipe B] Mode: 1920x1080@60Hz Connectors: eDP-1[29]
    CRTC[18] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[35] (NC)
  Test id#5 CRTC count 2
    CRTC[8] [Pipe A] Mode: 640x480@60Hz Connectors: HDMI-A-1[22] (NC)
    CRTC[18] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[35] (NC)
  Test id#6 CRTC count 2
    CRTC[13] [Pipe B] Mode: 640x480@60Hz Connectors: HDMI-A-1[22] (NC)
    CRTC[18] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[35] (NC)
Testing: clone-exclusive-crtc 3 connector combinations
  Test id#7 CRTC count 3
    CRTC[8] [Pipe A] Mode: 1920x1080@60Hz Connectors: eDP-1[29]
    CRTC[13] [Pipe B] Mode: 640x480@60Hz Connectors: HDMI-A-1[22] (NC)
    CRTC[18] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[35] (NC)
  Test id#8 CRTC count 3
    CRTC[13] [Pipe B] Mode: 1920x1080@60Hz Connectors: eDP-1[29]
    CRTC[8] [Pipe A] Mode: 640x480@60Hz Connectors: HDMI-A-1[22] (NC)
    CRTC[18] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[35] (NC)
Subtest clone-exclusive-crtc: SUCCESS (50.313s)

[   59.872283] WARNING: CPU: 1 PID: 3796 at drivers/gpu/drm/drm_irq.c:1089 drm_wait_one_vblank+0x10e/0x16c [drm]()
[   59.872288] vblank wait timed out on crtc 0
[   59.872291] Modules linked in: dm_mod iTCO_wdt iTCO_vendor_support snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic serio_raw pcspkr i2c_i801 lpc_ich mfd_core s
nd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore battery ac acpi_cpufreq i915 button video drm_kms_helper drm cfbfillrect cfbimgblt cfbcop
yarea option usb_wwan usbserial
[   59.872340] CPU: 1 PID: 3796 Comm: kms_setmode Tainted: G        W      3.18.0-rc3_drm-intel-nightly_f56717_20141105+ #1198
[   59.872345]  0000000000000000 0000000000000009 ffffffff81789002 ffff88017a627a88
[   59.872352]  ffffffff810368cc ffff88017ab80000 ffffffffa006aa9e ffff88017ab80000
[   59.872358]  0000000000000000 ffff8801759bb000 0000000000000000 0000000000000283
[   59.872366] Call Trace:
[   59.872380]  [<ffffffff81789002>] ? dump_stack+0x41/0x51
[   59.872390]  [<ffffffff810368cc>] ? warn_slowpath_common+0x78/0x90
[   59.872405]  [<ffffffffa006aa9e>] ? drm_wait_one_vblank+0x10e/0x16c [drm]
[   59.872414]  [<ffffffff8103697c>] ? warn_slowpath_fmt+0x45/0x4a
[   59.872423]  [<ffffffff8105f5df>] ? prepare_to_wait_event+0xb0/0xec
[   59.872438]  [<ffffffffa006aa9e>] ? drm_wait_one_vblank+0x10e/0x16c [drm]
[   59.872445]  [<ffffffff8105f8e9>] ? add_wait_queue+0x3c/0x3c
[   59.872484]  [<ffffffffa0124033>] ? i9xx_crtc_disable+0x66/0x353 [i915]
[   59.872520]  [<ffffffffa0128218>] ? __intel_set_mode+0xd60/0x13d4 [i915]
[   59.872527]  [<ffffffff8178610f>] ? printk+0x4f/0x54
[   59.872543]  [<ffffffffa006bff7>] ? drm_ut_debug_printk+0x59/0x5e [drm]
[   59.872579]  [<ffffffffa012a9da>] ? intel_set_mode+0xd/0x27 [i915]
[   59.872615]  [<ffffffffa012b5fd>] ? intel_crtc_set_config+0x767/0xac1 [i915]
[   59.872634]  [<ffffffffa0070f21>] ? drm_mode_set_config_internal+0x48/0xbd [drm]
[   59.872652]  [<ffffffffa0074934>] ? drm_mode_setcrtc+0x3e6/0x48b [drm]
[   59.872668]  [<ffffffffa0069738>] ? drm_ioctl+0x279/0x3bc [drm]
[   59.872676]  [<ffffffff810e86b6>] ? tlb_finish_mmu+0xb/0x2f
[   59.872693]  [<ffffffffa007454e>] ? drm_mode_setplane+0x1ce/0x1ce [drm]
[   59.872708]  [<ffffffffa0068ac7>] ? drm_gem_vm_close+0x2a/0x4b [drm]
[   59.872716]  [<ffffffff8111a53f>] ? do_vfs_ioctl+0x3ec/0x435
[   59.872724]  [<ffffffff8109d57a>] ? __audit_syscall_entry+0xb2/0xd2
[   59.872732]  [<ffffffff8100d27c>] ? syscall_trace_enter_phase1+0x11e/0x127
[   59.872739]  [<ffffffff8111a5d1>] ? SyS_ioctl+0x49/0x78
[   59.872745]  [<ffffffff8109d7a3>] ? __audit_syscall_exit+0x209/0x225
[   59.872753]  [<ffffffff8178e692>] ? system_call_fastpath+0x12/0x17
[   59.872757] ---[ end trace 9dd1ea0a051c93e4 ]---


==Reproduce steps==
---------------------------- 
1. ./kms_setmode --run-subtest clone-exclusive-crtc

Comment 1 Jani Nikula 2015-02-12 11:57:44 UTC

Please retest with current drm-intel-nightly.

Comment 2 lu hua 2015-02-13 06:51:54 UTC

root@x-bsw08:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_setmode --run-subtest clone-exclusive-crtc
IGT-Version: 1.9-g9846e7f (x86_64) (Linux: 3.19.0_drm-intel-nightly_dbd79c_20150213+ x86_64)
Testing: clone-exclusive-crtc 2 connector combinations
  Test id#1 CRTC count 2
    CRTC[20] [Pipe A] Mode: 1920x1080@60Hz Connectors: eDP-1[41]
    CRTC[25] [Pipe B] Mode: 640x480@60Hz Connectors: HDMI-A-1[34] (NC)
  Test id#2 CRTC count 2
    CRTC[25] [Pipe B] Mode: 1920x1080@60Hz Connectors: eDP-1[41]
    CRTC[20] [Pipe A] Mode: 640x480@60Hz Connectors: HDMI-A-1[34] (NC)
  Test id#3 CRTC count 2
    CRTC[20] [Pipe A] Mode: 1920x1080@60Hz Connectors: eDP-1[41]
    CRTC[30] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[47] (NC)
  Test id#4 CRTC count 2
    CRTC[25] [Pipe B] Mode: 1920x1080@60Hz Connectors: eDP-1[41]
    CRTC[30] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[47] (NC)
  Test id#5 CRTC count 2
    CRTC[20] [Pipe A] Mode: 640x480@60Hz Connectors: HDMI-A-1[34] (NC)
    CRTC[30] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[47] (NC)
  Test id#6 CRTC count 2
    CRTC[25] [Pipe B] Mode: 640x480@60Hz Connectors: HDMI-A-1[34] (NC)
    CRTC[30] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[47] (NC)
Testing: clone-exclusive-crtc 3 connector combinations
  Test id#7 CRTC count 3
    CRTC[20] [Pipe A] Mode: 1920x1080@60Hz Connectors: eDP-1[41]
    CRTC[25] [Pipe B] Mode: 640x480@60Hz Connectors: HDMI-A-1[34] (NC)
    CRTC[30] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[47] (NC)
  Test id#8 CRTC count 3
    CRTC[25] [Pipe B] Mode: 1920x1080@60Hz Connectors: eDP-1[41]
    CRTC[20] [Pipe A] Mode: 640x480@60Hz Connectors: HDMI-A-1[34] (NC)
    CRTC[30] [Pipe C] Mode: 640x480@60Hz Connectors: HDMI-A-2[47] (NC)
Subtest clone-exclusive-crtc: SUCCESS (43.524s)
root@x-bsw08:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# dmesg -r|egrep "<[1-4]>"|grep drm
<3>[  341.728152] [drm:i9xx_check_fifo_underruns [i915]] *ERROR* pipe B underrun
<3>[  341.744854] [drm:valleyview_pipestat_irq_handler [i915]] *ERROR* CPU pipe B FIFO underrun
<3>[  342.214618] [drm:valleyview_pipestat_irq_handler [i915]] *ERROR* CPU pipe A FIFO underrun
<3>[  342.214653] [drm:valleyview_pipestat_irq_handler [i915]] *ERROR* CPU pipe C FIFO underrun

Comment 3 Ander Conselvan de Oliveira 2015-06-04 18:16:58 UTC

This might have been fixed by Ville's VLV/CHV watermark rework: http://article.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/53515

Please test again with current -nightly.

Comment 4 lu hua 2015-06-05 03:33:42 UTC

(In reply to Ander Conselvan de Oliveira from comment #3)
> This might have been fixed by Ville's VLV/CHV watermark rework:
> http://article.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/53515
> 
> Please test again with current -nightly.

Test on following drm-intel-nightly kernel, it still exists. The patch doesn't merge yet?
commit 0761e2d5d55e8311950514fda1ec414838525985
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Thu Jun 4 16:19:46 2015 +0300

    drm-intel-nightly: 2015y-06m-04d-13h-19m-27s UTC integration manifest

Comment 5 Rami 2015-10-02 13:48:18 UTC

Reproduced on BSW with 4.3.0-rc2-drm-intel-nightly+

Hardware:
=========

Platform: Braswell M 
CPU : Intel(R) Celeron N3060 1.60GHz @ 1.6 GHz (family: 6, model: 76 stepping:
4)
SoC : BSW D0
QDF : K6XC
CRB : BRASWELL RVP Fab2
Mandatory Reworks : All 
Feature Reworks: F28, F32,F33 & F37
Optional reworks : O-01a


Software :
Linux distribution: Ubuntu 14.04 LTS 64 bits 
BIOS : BRAS.X64.B084.R00.1508310642
TXE FW : 2.0.0.2073
Ksc : 1.08

kernel 4.3.0-rc2-drm-intel-nightly+
commit 794e1cdfb84be003dbd287c69501c98ec280a89b
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Mon Sep 28 17:28:29 2015 +0300

    drm-intel-nightly: 2015y-09m-28d-14h-28m-11s UTC integration manifest

cairo: (HEAD, tag: 1.14.2) 93422b3cb5e0ef8104b8194c8873124ce2f5ea2d from
git://git.freedesktop.org/git/cairo
drm: (HEAD, tag: libdrm-2.4.64, tag: 2.4.64)
ab2fadabde3829b1ec56bd4756165dd9bd281488 from
git://git.freedesktop.org/git/mesa/drm
intel-driver: (HEAD, origin/master, origin/HEAD, master)
2a72f99d24714f2a58f400ef63b913d4cf9080b3 from
git://git.freedesktop.org/git/vaapi/intel-driver
libva: (HEAD, tag: libva-1.6.1, origin/v1.6-branch)
613eb962b45fbbd1526d751e88e0d8897af6c0e0 from
git://git.freedesktop.org/git/vaapi/libva
mesa: (HEAD, tag: mesa-10.6.7) 32efdc87cbf89cfe08ad9571cd756e27c803caa8 from
git://git.freedesktop.org/git/mesa/mesa
xf86-video-intel: (HEAD, origin/master, origin/HEAD, master)
f0fd4d500de03c30c7ce19915f85acadd1ca4e5d from
git://git.freedesktop.org/git/xorg/driver/xf86-video-intel
xserver: (HEAD, tag: xorg-server-1.17.2)
2123f7682d522619f101b05fb75efa75dabbe371 from
git://git.freedesktop.org/git/xorg/xserver

intel-gpu-tools: (HEAD, tag: intel-gpu-tools-1.12)
1f9e0550455be4b219954a026407dd23ec21b299 from
git://git.freedesktop.org/git/xorg/app/intel-gpu-tools

Comment 6 Jani Nikula 2015-10-30 13:23:33 UTC

Please try Ville's FIFO underrun elimination series [1] on top of drm-intel-nightly, also available at [2], and report back.

[1] http://mid.gmane.org/1446146763-31821-1-git-send-email-ville.syrjala@linux.intel.com
[2] git://github.com/vsyrjala/linux.git pch_fifo_underrun_fix_4

Comment 7 Jani Nikula 2015-11-12 15:09:11 UTC

(In reply to Jani Nikula from comment #6)
> Please try Ville's FIFO underrun elimination series [1] on top of
> drm-intel-nightly, also available at [2], and report back.
> 
> [1]
> http://mid.gmane.org/1446146763-31821-1-git-send-email-ville.syrjala@linux.
> intel.com
> [2] git://github.com/vsyrjala/linux.git pch_fifo_underrun_fix_4

The series has been merged to drm-intel-nightly. Please retest that.

Comment 8 Wayne Boyer 2016-01-13 23:58:15 UTC

AFAIU, Ville's FIFO underrun elimination series does not affect BSW.  Is this still a problem with a recent drm-intel-nightly kernel?

Comment 9 russ.sage 2016-03-08 01:31:12 UTC

I verified this on a Cyan DVT running Coreboot 7287.57.32 and Google Partner image R50 7982 2/28. After plugging in the HDMI monitor and moving the cursor quickly across the display border there was no issue with the screen going blank. Issue is fixed, can not reproduce.

Comment 10 Jani Saarinen 2016-12-09 11:23:39 UTC

Based on comment, closed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.