| Summary: | Mesa: MSVC 2010/2012 Compile error | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Michael Bachmann <mr.bachmann> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | blocker | ||
| Priority: | medium | ||
| Version: | 10.3 | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Windows (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | patch for the file src/mesa/main/macros.h | ||
|
Description
Michael Bachmann
2014-11-05 15:08:04 UTC
This was already fixed on mesa master in a similar fashion quite a while ago - commit 9608193cbc6ea14e49adcd0193f9e7c6058d5a2f. I guess we forgot about nominating it for 10.3 branch, I'm going to do that now. Roland, Can we encourage "newcomers" to use MSVC 2013 and later (if ever available) ? This way once you guys (and others) are over to 2013 we can just go with - anything prior to MSVC2013 is not supported :P I.e. having a gradual transition period is always a nice. (In reply to Emil Velikov from comment #2) > Roland, > Can we encourage "newcomers" to use MSVC 2013 and later (if ever available) > ? This way once you guys (and others) are over to 2013 we can just go with - > anything prior to MSVC2013 is not supported :P > I.e. having a gradual transition period is always a nice. I don't think this particular bug is actually dependent on msvc version (it is, however, dependent on release vs. debug build). But in general I don't have anything against recommending newer msvc versions. Roland, Indeed this issue is not related (does not seem) to the verison of msvc yet it's a nice reminder about the topic, plus an humble ping for Michael :) Pushed to the 10.3 branch. Issue will be fixed in mesa 10.3.3. commit d5700dc276008decb2a5d63bfa38522c5f4ad3f3 Author: Brian Paul <brianp@vmware.com> Date: Wed Sep 10 08:16:24 2014 -0600 mesa: fix UNCLAMPED_FLOAT_TO_UBYTE() macro for MSVC MSVC replaces the "F" in "255.0F" with the macro argument which leads to an error. s/F/FLT/ to avoid that. It turns out we weren't using this macro at all on MSVC until the recent "mesa: Drop USE_IEEE define." change. Reviewed-by: Roland Scheidegger <sroland@vmware.com> (cherry picked from commit 9608193cbc6ea14e49adcd0193f9e7c6058d5a2f) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85918 Nominated-by: Roland Scheidegger <sroland@vmware.com> Thank you for taking care about this issue and for including the fix in Version 10.3.3. (In reply to Emil Velikov from comment #2) > Roland, > Can we encourage "newcomers" to use MSVC 2013 and later (if ever available) > ? This way once you guys (and others) are over to 2013 we can just go with - > anything prior to MSVC2013 is not supported :P > I.e. having a gradual transition period is always a nice. I'm afraid VMware needs to build with MSVC 2012. See explanation on http://lists.freedesktop.org/archives/piglit/2014-October/013129.html It's OK recommending MSVC 2013, but we need to continue to support MSVC 2012 a bit longer. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.