Summary: | reworked Special Character dialog is throwing a compiler assert error in vcl builder | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | V Stuart Foote <vstuart.foote> |
Component: | UI | Assignee: | Caolán McNamara <caolanm> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | chris.sherlock79, eszkadev, fitojb, s.mehrbrodt, vstuart.foote |
Version: | 4.4.0.0.alpha1 | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | target:4.4.0 | ||
i915 platform: | i915 features: | ||
Attachments: |
Clip of MS VS2012 assert error message
WinDbg stack strace of all threads TB45 dbg build back trace of assert error (and crash) on 32-bit Linux bt following core dump for assert error in VCL builder.hxx bt following core dump for asser error in VCL builder.hxx more complete symbols |
Description
V Stuart Foote
2014-11-05 20:37:36 UTC
Created attachment 108986 [details]
Clip of MS VS2012 assert error message
Created attachment 108987 [details]
WinDbg stack strace of all threads
Happening in Writer, Impress, Draw, and Calc components--but not Math which looks to not be using the dialog. I noted that yesterday, but doesn’t happen for me in today’s build. Can you re-check? On Windows 7 sp1, 64-bit en-US Saw it on today's Version: 4.4.0.0.alpha1+ Build ID: 3c58f0768049718fae3d47d5ebfa6c7485ad52b1 TinderBox: Win-x86@39, Branch:master, Time: 2014-11-05_06:43:51 Version: 4.4.0.0.alpha1+ Build ID: 768d22a83e7e6aae430b2e5e4ed28f2574aad12d TinderBox: Win-x86@39, Branch:master, Time: 2014-11-04_09:19:00 The build from 29th still had the old style dialog, and did not error Version: 4.4.0.0.alpha1+ Build ID: 62c125bbb4d27631af6cbcb498e765c0b215b734 TinderBox: Win-x86@39, Branch:master, Time: 2014-10-29_19:16:52 Just grabbed the 2014-11-01 TB39 build, assert error present there. Version: 4.4.0.0.alpha1+ Build ID: 1baad070d8c2a38581cf33d803c5043f1974647f TinderBox: Win-x86@39, Branch:master, Time: 2014-11-01_00:15:06 (In reply to V Stuart Foote from comment #6) > Just grabbed the 2014-11-01 TB39 build, assert error present there. Today’s November the sixth. You should download a current build. TB 39 contains a build for today. Re-test that instead of an outdated one. http://dev-builds.libreoffice.org/daily/master/Win-x86@39/current/ Still November 5th here in Texas-- but had to wait for the TB39 build for the 6th UTC to upload to the TB. Just got it. Version: 4.4.0.0.alpha1+ Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51 Sorry, still throwing the assert error--Writer, Impress, Calc, Draw It's having problems either getting the button, or casting from a Window pointer to an OKButton pointer. Might need to split that assert into two asserts to determine which is which. Chris Sherlock committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab2ed5a360e565299ae558b97bc39cf7aba1a81c vcl: split asserts in VclBuilder::get() for fdo#85939 It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The above patch is not a fix, but should help us track down what's going on. When the next build occurs, can you attach the assert message? (In reply to Chris Sherlock from comment #11) > The above patch is not a fix, but should help us track down what's going on. > When the next build occurs, can you attach the assert message? @Chris, will do but will have to wait for the next TB39 build to post tonight. @Adolpho, are you able role one to check before then? And guess I should probably ask, did you need us to keep poking at this? I am sure its been frustrating, and sorry if I've been a little dense. Stuart Does this by any chance happen on Linux at all? Created attachment 109068 [details] TB45 dbg build back trace of assert error (and crash) on 32-bit Linux (In reply to Chris Sherlock from comment #13) > Does this by any chance happen on Linux at all? Yes, we do get the same assert failure on 32-bit Linux, back trace attached. On Fedora 20 32-bit with Version: 4.4.0.0.alpha1+ Build ID: d59b9b4af36148e4d8df8f3e3492116d378642e2 TinderBox: Linux-rpm_deb-x86@45-TDF-dbg, Branch:master, Time: 2014-11-06_03:11:43 (In reply to Chris Sherlock from comment #13) > Does this by any chance happen on Linux at all? Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8da62747d0d870db3b9746b765d18b2a62e4b31b Resolves: fdo#85939 its not an OKButton anymore It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 109087 [details]
bt following core dump for assert error in VCL builder.hxx
On Fedora 20 64-bit with
Version: 4.4.0.0.alpha2+
Build ID: 0adb90115596ce69e1d80becdaa39e23197fe454
TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time: 2014-11-06_23:39:21
On the console get this warning and core dump...
warn:vcl.layout:3115:1:include/vcl/builder.hxx:406: .ui widget "ok" needs to correspond to vcl type 8OKButton
soffice.bin: /home/buildslave/source/libo-core/include/vcl/builder.hxx:408: T* VclBuilder::get(T*&, const rtl::OString&) [with T = OKButton]: Assertion `dynamic_cast<T*>(w)' failed.
Aborted (core dumped)
(In reply to Commit Notification from comment #16) > Caolán McNamara committed a patch related to this issue. > It has been pushed to "master": > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=8da62747d0d870db3b9746b765d18b2a62e4b31b Oops, sorry missed this commit while I was gathering the additional bt. Thanks all! Created attachment 109091 [details]
bt following core dump for asser error in VCL builder.hxx more complete symbols
Swapping out the attached bt, I hadn't added in the full gcc symbols on this 64-bit Fedora VM.
Sorry for the noise.
Is that warning happening after Caolan's commit? (In reply to Chris Sherlock from comment #20) > Is that warning happening after Caolan's commit? No, for the prior builds that include your split of the Assert. fix verified with debug TB39 Version: 4.4.0.0.alpha2+ Build ID: e7fbe37c56d78af757f975b280bf113fb2fe40fd TinderBox: Win-x86@39, Branch:master, Time: 2014-11-08_12:46:44 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.