Summary: | xdg-open does not handle x-schemes with no URL correctly (suggested PATCH) | ||
---|---|---|---|
Product: | Portland | Reporter: | aayla.secura.1138 |
Component: | xdg-utils | Assignee: | Portland Bugs <portland-bugs> |
Status: | RESOLVED MOVED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | 1.1.0 rc2 | ||
Hardware: | All | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 23105 | ||
Attachments: | patch for xdg-utils v1.1.1 |
Description
aayla.secura.1138
2014-11-16 11:20:55 UTC
Re: legacy/applnk support I'd rather you not conflate that here, to deal with it in a separate patch. In doing so, I'd also opt for dropping applnk support rather than adding it. And, let's deal with quoting separately too please. Is there some reason you opted for this approach rather than what I proposed in bug #66670 already? While you're at it, please add patches as attachments rather than inline And, thanks. (In reply to Rex Dieter from comment #1) > Re: legacy/applnk support > > I'd rather you not conflate that here, to deal with it in a separate patch. > In doing so, I'd also opt for dropping applnk support rather than adding it. > > And, let's deal with quoting separately too please. Is there some reason > you opted for this approach rather than what I proposed in bug #66670 > already? > > While you're at it, please add patches as attachments rather than inline > > And, thanks. Sorry, I wasn't sure if I should post separate patches, my main idea was to fix the handling of schemes with empty URLs. As for the applnk - I wasn't sure if it should be dropped completely, but it bugged me that it was supported in one function and not the rest. As for the quoting - as far as I could see, you wrapped all the arguments in single quotes at the point of evaluation - that causes several problems: some of those arguments (that are specified in the desktop file) may be options to the programs (for example --writer in libreoffice's dekstop file) and if they are put in single quotes it causes an error; that's why I only wrapped the argument provided by the user in single quotes; secondly, if that argument (path to file or url or whatever) contains a single quote, it is not escaped (hence I replace any single quote with '"'"' before wrapping the whole arg in single quotes) Your code does however fix the issue with %i and %c, which I forgot to adress. Sorry, new to bugzilla in general, will post patches as attachments from now on :) (is there a way to edit my comment to remove the patch?) Created attachment 123399 [details] [review] patch for xdg-utils v1.1.1 This still hasn't been resolved, so I posted a minimal patch that fixes the problem. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/xdg-utils/issues/75. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.