| Summary: | BUILD FAILED: why : forced (dist) upgrade for gcc 3.4.6 over a BIT COUNT, __builtin_ctz | ||
|---|---|---|---|
| Product: | DRI | Reporter: | debguy <johnandsara2> |
| Component: | DRM/Radeon | Assignee: | Default DRI bug account <dri-devel> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | DRI git | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
debguy
2014-11-17 04:46:19 UTC
(all i meant with comments are: goal is not to continually upgrade gcc, bison, etc, causing old code to be incompatible and faile: but to compile new software: which is easily possible with early tools, new ELF or arch aside. __builtin could be a macro or check to see if accel was avail, rather than using a tweak in gcc only new gcc has. gcc is not the place to add convenience functions: it's just not where they go. libc might be. even then for a bit count that's the wrong avenue to expect C libs to be a "perl, unix in a big module" of every new new bithack stacked against every kernel support of. i was pretty user processor support hacks are per arch in kernel, and lib c sparsely supported them and driver coders commonly checked in the driver code where useful for such, having both choices on hand) Wow. A couple of rants about software engineering best practices from a guy using a gcc release that's literally more than 10 years old. 3.4.0 (which supports the builtin) is actually *older* than what you're using. Dear debguy/johnandsara2 As Matt, pointed out bashing is not most appropriate way to approach any person or project. Additionally I'm not sure why you build the radeon code, considering that (based on your statement) you're not using it. If you have a patch that adds a fall back in case of missing __builtin_ctz(old compiler etc.), that follows the surrounding coding style, please submit it to the dri-devel mailing list via git send-email. Thanks P.S. Using autoconf macros might be a nice way to detect the presence of __builtin**. Take a look at the mesa project if you'd like an example. Ball's in the reporter's court. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.