| Summary: | [i965 Bisected]ES2-CTS.gtf.GLCoverage.CoverageGL fails due to enable GL_RGB and GL_RGBA | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Eduardo Lima Mitev <elima> |
| Status: | VERIFIED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | normal | ||
| Priority: | high | CC: | idr, itoral |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=88079 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
lu hua
2014-12-11 03:27:09 UTC
The offending patch explicitly checks for a GLES3 context. If the failing test is a GLES2 as it seems, then it is not clear why is picking the invalid enums. Can we confirm the test is actually running a GLES2 profile? I will take a closer look. (In reply to Eduardo Lima Mitev from comment #1) > The offending patch explicitly checks for a GLES3 context. If the failing > test is a GLES2 as it seems, then it is not clear why is picking the invalid > enums. > > Can we confirm the test is actually running a GLES2 profile? > > I will take a closer look. ES3 contexts are supposed to be backwards compatible with ES2. On platforms that support ES3, Mesa (and other implementations?) always gives an ES3 context. Also, from the looks of the command line, this is run from the ES3 conformance suite from Khronos. Lu, is that correct? (In reply to Ian Romanick from comment #3) > Also, from the looks of the command line, this is run from the ES3 > conformance suite from Khronos. Lu, is that correct? Yes. Ok, then I guess adding a ctx->Version >= 30 check is what's missing. Will submit updated patch to ML. Thanks for the insights. Oops, please ignore my last comment. Just checked that _mesa_is_gles3() already checks version >= 30. So I need other way to identify specific versions of the GLES profile. (In reply to Eduardo Lima Mitev from comment #6) > Oops, please ignore my last comment. Just checked that _mesa_is_gles3() > already checks version >= 30. So I need other way to identify specific > versions of the GLES profile. I think it must be something deeper than that. To me, it appears that the dEQP test is expecting different behavior than the Khronos GLES3 conformance test. I think the unsized internal formats are only allowed with certain format and type combinations. Perhaps 7894278 is just too lax? (In reply to Ian Romanick from comment #7) > I think the unsized internal formats are only allowed with certain > format and type combinations. Perhaps 7894278 is just too lax? See bug 88079. I think it describes the same issue. The spec is not always clear where GL_RGB and GL_RGBA (or other unsized internal formats) are valid internal formats, but in some cases it is very clear where it is not, like in glRenderbufferStorageMultisample(): "internalformat must be a sized internal format that is color-renderable,depth-renderable, or stencil-renderable" I just submitted a patch for reviewal <http://lists.freedesktop.org/archives/mesa-dev/2015-January/074122.html>. Perhaps it also fixes ES3-CTS.gtf.GL3Tests.color_buffer_float.color_buffer_unsupported_format. Could you please confirm? (In reply to Eduardo Lima Mitev from comment #8) > (In reply to Ian Romanick from comment #7) > > I think the unsized internal formats are only allowed with certain > > format and type combinations. Perhaps 7894278 is just too lax? > > See bug 88079. I think it describes the same issue. > The spec is not always clear where GL_RGB and GL_RGBA (or other unsized > internal formats) are valid internal formats, but in some cases it is very > clear where it is not, like in glRenderbufferStorageMultisample(): > > "internalformat must be a sized internal format that is > color-renderable,depth-renderable, or > stencil-renderable" > > I just submitted a patch for reviewal > <http://lists.freedesktop.org/archives/mesa-dev/2015-January/074122.html>. > Perhaps it also fixes > ES3-CTS.gtf.GL3Tests.color_buffer_float.color_buffer_unsupported_format. > > Could you please confirm? Test this patch, It works well. passes with Mesa master (tested d74a817) Verified.Fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.