Bug 87243

Summary:	xfwp fails during build
Product:	xorg	Reporter:	thisistotallyannoying
Component:	App/other	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED WORKSFORME	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description thisistotallyannoying 2014-12-11 18:21:57 UTC

Failing here on Ubuntu:

http://31.130.202.83/bulk-logs/Linux/Ubuntu/x86_64/14.04/HEAD//20141116.1253/x11_xfwp_xfwp-1.0.3/stage_build.html

and here on CentOS 7:

--- io.o ---
io.c: In function 'ProcessServerReply':
io.c:1039:7: error: implicit declaration of function 'swab' [-Werror=implicit-function-declaration]
       swab((char *) &prefix.majorVersion,
       ^
io.c:1039:7: warning: nested extern declaration of 'swab' [-Wnested-externs]
cc1: some warnings being treated as errors
*** [io.o] Error code 1

bmake: stopped in /usr/pkgsrc/x11/xfwp/work/xfwp-1.0.3
1 error

and hacked into submission in Mageia:

http://svnweb.mageia.org/packages/cauldron/xfwp/current/SPECS/xfwp.spec?revision=744962&view=markup

Adding those configure arguments under pkgsrc gives us:

configure: WARNING: You have chosen not to turn some select compiler warnings into errors.  This should not be necessary.  Please report why you needed to do so in a bug report at https://bugs.freedesktop.org/enter_bug.cgi?product=xorg

Hence this report. Please, fix and we'll update our repository accordingly.

Comment 1 Alan Coopersmith 2015-05-08 05:32:24 UTC

io.c includes <unistd.h>

swab() is required by various standards to be defined in <unistd.h>,
as documented in:
http://pubs.opengroup.org/onlinepubs/009695399/functions/swab.html
http://man7.org/linux/man-pages/man3/swab.3.html

Thus if this isn't working for your platform, there's a problem in
your libc headers, not xfwp.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.