Bug 87371

Summary:	brw_vec4_visitor.cpp:2435: undefined reference to `_mesa_get_sampler_uniform_value'
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	medium	CC:	brianp
Version:	git	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	remove extern "C" stuff from brw_vec4_visitor.cpp updated patch

Description Vinson Lee 2014-12-16 17:43:22 UTC

mesa: c6e8d2c6593820e48eb2f1088c4d06ad633e509e (master 10.5.0-devel)

$ make check
[...]
  CXXLD    test_vec4_copy_propagation
./.libs/libi965_dri.a(brw_vec4_visitor.o): In function `brw::vec4_visitor::visit(ir_texture*)':
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp:2435: undefined reference to `_mesa_get_sampler_uniform_value'
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp:2438: undefined reference to `_mesa_get_sampler_array_nonconst_index'

Comment 1 Brian Paul 2014-12-16 18:05:34 UTC

Created attachment 110918 [details] [review]
remove extern "C" stuff from brw_vec4_visitor.cpp

Does this fix it, Vinson?

Comment 2 Brian Paul 2014-12-16 18:07:33 UTC

Created attachment 110919 [details] [review]
updated patch

Err, try this one instead.

Comment 3 Vinson Lee 2014-12-17 05:40:15 UTC

commit fc016bc0f3d83bbf3eb968938f4bc9df55214ecd
Author: Mark Janes <mark.a.janes@intel.com>
Date:   Tue Dec 16 14:29:28 2014 -0800

    i965: remove includes of sampler.h from extern "C" blocks
    
    C linkage was removed from functions in program/sampler.cpp.  However,
    some cpp files include program/sampler.h within extern "C" blocks,
    causing link errors for test_vec4_copy_propagation.
    
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Tested-by: Ian Romanick <ian.d.romanick@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.