| Summary: |
NameError: name 'dirname' is not defined |
| Product: |
piglit
|
Reporter: |
Vinson Lee <vlee> |
| Component: |
tests | Assignee: |
Piglit Mailing List <piglit> |
| Status: |
RESOLVED
FIXED
|
QA Contact: |
Piglit Mailing List <piglit> |
| Severity: |
blocker
|
|
|
| Priority: |
medium
|
CC: |
baker.dylan.c, mark.a.janes
|
| Version: |
unspecified | Keywords: |
bisected, regression |
| Hardware: |
x86-64 (AMD64) | |
|
| OS: |
Linux (All) | |
|
| Whiteboard: |
|
|
i915 platform:
|
|
i915 features:
|
|
|---|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
piglit: 688294703e580c2d9b77e814cdd3ae68d96c57a3 (master) [ 99%] Generating cl_store_tests.list Traceback (most recent call last): File "generated_tests/generate-cl-store-tests.py", line 35, in <module> utils.safe_makedirs(dirname) NameError: name 'dirname' is not defined commit 688294703e580c2d9b77e814cdd3ae68d96c57a3 Author: Dylan Baker <dylanx.c.baker@intel.com> Date: Wed Dec 17 15:28:59 2014 -0800 generated_tests: Actually catch exception in os.makedirs Patch b59ff71eb was supposed to fix os.makedirs exceptions, but falls short because of a missing else statement that causes all of the caught exceptions to fall back to raise. This corrects, it also pulls the duplicate functions out into a shared module. v2: - remove accidentally included hunk (Mark) v3: - Actually include the modules directory in the commit (Mark) Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com> Reviewed-by: Mark Janes <mark.a.janes@intel.com>