| Summary: | Bashisms in intel_gpu_abrt script | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Vincent Cheng <vincentc1208> |
| Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | intel-gfx-bugs, vincentc1208 |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Err, I mean, forwarded from https://bugs.debian.org/772339 Thanks, commit cb512b6470fa848c9b351c2090cd3e3f588cfc5f Author: Vincent Cheng <vincentc1208@gmail.com> Date: Wed Dec 31 10:39:51 2014 +0000 tools/intel_gpu_abrt: Fix bashism intel-gpu-tools ships a #!/bin/sh script that has bash-specific syntax (which breaks on distros such as Debian and Ubuntu where /bin/sh is a symlink to something other than bash). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87888 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
intel-gpu-tools ships a #!/bin/sh script that has bash-specific syntax (which breaks on distros such as Debian and Ubuntu where /bin/sh is a symlink to something other than bash). Here's a small patch which fixes this. Thanks for considering! (Forwarded from diff -Nru a/tools/intel_gpu_abrt b/tools/intel_gpu_abrt --- a/tools/intel_gpu_abrt 2013-02-19 18:05:47.000000000 -0800 +++ b/tools/intel_gpu_abrt 2014-12-30 17:12:56.499574747 -0800 @@ -1,6 +1,6 @@ #!/bin/sh -if [[ $UID -ne 0 ]]; then +if [ $(id -ru) -ne 0 ]; then echo "$0 must be run as root" exit 1 fi