| Summary: | Please add bash-completion for mbimcli | ||
|---|---|---|---|
| Product: | libmbim | Reporter: | marius |
| Component: | General | Assignee: | Aleksander Morgado <aleksander> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=87900 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
marius
2014-12-31 11:14:09 UTC
Done in git master. Great! But it is not complete, it seems? (In reply to marius from comment #2) > Great! But it is not complete, it seems? What do you mean not complete? It should take the command names from --help-all. If you just looked at the patch: the explicitly listed commands are because they require additional arguments. All the commands without additional arguments are not needed in the explicit list as they're taken directly from --help-all. Ah, didn't see that in all the script magic. It works fine when I actually try to install it. I just noticed that tabbing without any '-' entered gives nothing. That is probably how it should be when no input other than options is expected? In this case, if possible, it would be nice if tabbing without arguments would work as tabbing with "-" entered. That is accomplished by removing the "if [[ $cur == -* ]]; then" check. I think that gives a better result with the current mbimcli. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.