Bug 88073

Summary:	FORMATTING: Drawing Object Styles lost after template update
Product:	LibreOffice	Reporter:	Sean Carlos <sean.carlos>
Component:	Presentation	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---	QA Contact:
Severity:	major
Priority:	medium	CC:	pierre.choffardet, todventtu
Version:	Inherited From OOo
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Sean Carlos 2015-01-05 22:00:43 UTC

In a presentation accepting changes from an updated template (at file open) causes the "Drawing Object Styles" in the presentation to revert to the LO defaults, rather than those in the underlying template. This results in formating loss assuming these styles from the template were not already the LO defaults. The separate "Presentation" Styles work as expected. The problem is not new.

Steps to reproduce

1. Create a new presentation

2. Modify the "Default" Drawing Object Style in the slide master. (View -> Slide Master -> Master; F11 to view styles and formatting, click top left icon in "Drawing Object Styles" pane, right click on "Default" to modify the style.

As an example, change the font. Change the area color.

3. Save the presentation as a new template: File -> Templates -> Save as template

4. Create, save and close a new presentation based on this template, any data will do. Note the "Default" Drawing Object styles are inherited from the template.

5. Edit / modify the underlying template, any change will do. Save and close.

6. Open the test presentation based on the template. Accept the "template has been modified, update styles" prompt. Review the "Default" drawing styles attributes. They're no longer those of the template, they've reverted back to the LO defaults.

I've marked this as "major" in severity as this is a type of data loss. The user needs to understand why their formatting has been lost and manually redefine each impacted style, a task easier said than done. I suspect a work around would be to import the slides into a new presentation based on the template, but that would result in the loss of comments, a bug reported awhile back.

Comment 1 Pierre C 2015-01-06 07:35:20 UTC

It this bug

https://bugs.freedesktop.org/show_bug.cgi?id=83569

the same problem ?

Comment 2 Sean Carlos 2015-01-06 10:55:57 UTC

Thanks for seeing this Pierre! Our reports are most likely the same underlying issue (style formatting problems related to applying an updated template to an existing presentation). although we describe the problem a bit differently.

I'm not exactly sure from the detail in your report which styles (standard, custom) are overwritten at what level (slide master? individual slide). I would stress (and perhaps the solution is to add these points to your report and mark this as a duplicate):

- the bug impacts the standard Drawing Object styles personalized in a template master slide

- any template change - not necessarily to a style - will cause the standard drawing object styles in dependent presentations to revert back to the LibreOffice defaults, ignoring what is defined / personalized in the template master slide - thus overwriting the Drawing Object styles the template previously provided the presentation.

In a quick test I also note that does seem that personalizations applied at the slide level (not the template nor master slide) are not changed.

I did not verify what happens to custom Drawing Object Styles which can be defined in a template.

Comment 3 Pierre C 2015-01-06 21:35:56 UTC

Hi Sean Carlos
In my tests, I found that all LO version (from 3.x) were impacted. I discover this problem, when for the first time, I tried to use impress template inherit feature. 
Did you use this feature before ?

Comment 4 Beluga 2015-01-15 17:11:12 UTC

(In reply to Sean Carlos from comment #0)
> 5. Edit / modify the underlying template, any change will do. Save and close.
> 
> 6. Open the test presentation based on the template.  Accept the "template
> has been modified, update styles" prompt.  Review the "Default" drawing
> styles attributes.  They're no longer those of the template, they've
> reverted back to the LO defaults.

How do you save the template? I just saved as template, chose same name, overwrote. Then when I opened my presentation, it didn't prompt to update styles and they had not changed (I changed the area color).

Also, what operating system are you using?

Change back to UNCONFIRMED after providing the information.

Win 7 64-bit Version: 4.5.0.0.alpha0+
Build ID: b3b4bbaf6cbd2226b659fea7d6ae473ccf84e9dd
TinderBox: Win-x86@39, Branch:master, Time: 2015-01-12_06:13:44

Comment 5 Sean Carlos 2015-01-15 18:24:40 UTC

OS: Linux

If you don't get the overwrite option, something is wrong - most likely the template is no longer associated with your presentation.

Comment 6 Beluga 2015-01-15 18:45:24 UTC

(In reply to Sean Carlos from comment #5)
> OS: Linux
> 
> If you don't get the overwrite option, something is wrong - most likely the
> template is no longer associated with your presentation.

But what Linux distro / version?

I tried on Ubuntu, but it doesn't ask to update styles either.

Ubuntu 14.10 64-bit Version: 4.5.0.0.alpha0+
Build ID: 7201fa0dddd7dd0352f69fd2b2b64efcb361ccad
TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time: 2015-01-11_23:28:55

Comment 7 Sean Carlos 2015-01-15 18:57:49 UTC

The bug is old, it can be verified using the latest LO official version, I'm using the latest LO on Fedora but I really doubt that is relevant.

If you are not seeing the templated has been updated message, then you have a different problem (you should see it) I suspect that either your presentation doesn't have an associated template or the current template location isn't the location known to the presentation.

Comment 8 Beluga 2015-01-15 19:25:55 UTC

(In reply to Sean Carlos from comment #7)
> If you are not seeing the templated has been updated message, then you have
> a different problem (you should see it) I suspect that either your
> presentation doesn't have an associated template or the current template
> location isn't the location known to the presentation.

Agh, it was because in 4.5 alpha there is not an edit button for templates and I was unknowingly opening a new presentation based on the template by double clicking it.
With 4.3.3 I can reproduce.
I could also repro with 3.3.0.

Ubuntu 14.10 64-bit
Version: 4.3.3.2
Build ID: 430m0(Build:2)

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.