Bug 88189

Summary: piglit-glx-util.h:30:21: fatal error: X11/Xmd.h: No such file or directory
Product: piglit Reporter: Vinson Lee <vlee>
Component: testsAssignee: Piglit Mailing List <piglit>
Status: RESOLVED FIXED QA Contact: Piglit Mailing List <piglit>
Severity: blocker    
Priority: medium CC: baker.dylan.c, laura
Version: unspecifiedKeywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2015-01-08 02:15:19 UTC
piglit: 866ac19995e7a004a12ce746395e1f2165fe21bc (master)

MinGW build error.

In file included from tests/spec/arb_direct_state_access/dsa-utils.h:41:0,
                 from tests/spec/arb_direct_state_access/bind-texture-unit.c:31:
tests/util/piglit-glx-util.h:30:21: fatal error: X11/Xmd.h: No such file or directory
 #include "X11/Xmd.h"
                     ^

commit 568ebeabec5bcbc7c1e66b11013db4a42bda24a0
Author: Laura Ekstrand <laura@jlekstrand.net>
Date:   Fri Oct 31 14:00:46 2014 -0700

    arb_direct_state_access: Testing glBindTextureUnit.
Comment 1 Laura Ekstrand 2015-01-08 03:20:01 UTC
This bug was not caused by my commit because my commits did not touch piglit-glx-util.h: http://cgit.freedesktop.org/piglit/log/tests/util/piglit-glx-util.h.
Comment 2 Vinson Lee 2015-01-08 03:45:51 UTC
Windows and Mac OS X builds are also broken with same build error.

e044d3196a72b5efa394adb64d77318aaa6be04e is the first bad commit
commit e044d3196a72b5efa394adb64d77318aaa6be04e
Author: Laura Ekstrand <laura@jlekstrand.net>
Date:   Mon Oct 13 12:01:47 2014 -0700

    arb_direct_state_access: DSA 2D Textures "hello world" test.
    
    Dylan Baker: all.py: Add dsa tests.

:040000 040000 f064909ce78b0b54af7db6ad6d92277a16b5a2bd cfe0e690b50e400e866b3f2422392f97b9946033 M	tests
bisect run success
Comment 3 Jose Fonseca 2015-01-08 10:46:33 UTC
Should be fixed by

commit dedb0a995dacb6b8794692d35ba0f12f2a29835f
Author: José Fonseca <jfonseca@vmware.com>
Date:   Thu Jan 8 10:45:06 2015 +0000

    arb_direct_state_access: Remove unnecessary piglit-glx-util.h include.
    
    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=88189
    
    Trivial.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.