Bug 88220

Summary: -bash: syntax error near unexpected token `('
Product: DRI Reporter: lu hua <huax.lu>
Component: DRM/IntelAssignee: Chris Wilson <chris>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: hengx.ding, intel-gfx-bugs
Version: unspecified   
Hardware: All   
OS: Linux (All)   
URL: http://xkcd.com/327/
Whiteboard:
i915 platform: i915 features:

Description lu hua 2015-01-09 06:13:17 UTC
==System Environment==
--------------------------
Regression: no, new case

Non-working platforms: all

==kernel==
--------------------------
drm-intel-fixes/e3e6efcd638d3caa18d9e89f235c7d6fc32c1f0b

==Bug detailed description==
-----------------------------
More than 1000+ new cases with (bcs) and (rcs) fail, due to unexpectd token ‘(’。

output:
-bash: syntax error near unexpected token `('

==Reproduce steps==
---------------------------- 
1. ./gem_concurrent_blit --run-subtest cpu-bcs-early-read-forked-hang(bcs)
Comment 1 Jani Nikula 2015-01-09 08:26:17 UTC
I'm guessing it's caused by IGT

commit 16bafdf5bf0248c02ea9824aca003b2a23d464be
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Sep 4 09:26:24 2014 +0100

    igt/gem_concurrent_blit: Inject hangs before verifying contents

Please roll back to an earlier commit of IGT as a quick workaround.
Comment 2 Chris Wilson 2015-01-09 09:08:32 UTC
Pardon? The bug is in the test runner...
Comment 3 Jani Nikula 2015-01-09 09:32:40 UTC
Sure, but isn't this the change that screwed up the test runner? Or is there a change that I missed in the test runner that regressed?
Comment 4 Chris Wilson 2015-01-12 10:57:34 UTC
QA's test runner appears to be a poorly written bash script.
Comment 5 Chris Wilson 2015-01-12 10:59:56 UTC
Or more generally, uses bash to execute a test in a very loose manner.
Comment 6 Rodrigo Vivi 2015-01-12 20:29:37 UTC
Did it ever worked?

It is not listed on subtests and here it doesn't work even before this commit 16bafdf5b.

If this is really a different test case why don't we use: cpu-bcs-early-read-forked-hang_bcs instead? This would keep igt standard and list it as a sub test.
Comment 7 Chris Wilson 2015-01-12 20:49:07 UTC
Yes. The bug is in how the test is executed. It is an utterly trivial bug.
Comment 8 lu hua 2015-01-13 07:44:41 UTC
(In reply to Rodrigo Vivi from comment #6)
> Did it ever worked?
> 
> It is not listed on subtests and here it doesn't work even before this
> commit 16bafdf5b.
> 
> If this is really a different test case why don't we use:
> cpu-bcs-early-read-forked-hang_bcs instead? This would keep igt standard and
> list it as a sub test.

It always has this issue. I also test commit before 16bafdf5b.
Comment 9 Chris Wilson 2015-01-13 09:13:33 UTC
*** Bug 88349 has been marked as a duplicate of this bug. ***
Comment 10 lu hua 2015-01-16 05:35:00 UTC
gem_concurrent_blit has 1575 subcase, 1103 has '('. 
We add '\', the case is executed,  ./gem_concurrent_blit --run-subtest cpu-bcs-early-read-forked-hang\(rcs\)

1575 subcase, one sub case takes 3min on average. On this speed, we need 80+ hours for whole case gem_concurrent_blit.
Comment 11 Daniel Vetter 2015-01-22 08:51:07 UTC
commit fbcc7ba20f5a45a6e2fc9e74a68608ebc804ec29
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Jan 22 09:43:10 2015 +0100

    tests/gem_concurrent_blt: Adjust subtest naming

I guess the amount of tests should be tracked somewhere else ... No idea yet what to do there.
Comment 12 lu hua 2015-01-26 07:52:34 UTC
Verified.Fixed.
[root@x-ivb9 tests]# ./gem_concurrent_blit --run-subtest prw-rcs-overwrite-source-forked-hang-blt
IGT-Version: 1.9-gfa94e01 (x86_64) (Linux: 3.19.0-rc5_drm-intel-nightly_67e9eb_20150125_debug+ x86_64)
using 2x512 buffers, each 1MiB
Subtest prw-rcs-overwrite-source-forked-hang-blt: SUCCESS (65.689s)
Comment 13 Elizabeth 2017-10-06 14:32:27 UTC
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.