Summary: | Sidebar: Undocked sidebar opened by call to Styles and Formatting is not dismissed with another call | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | tmacalp <tmacalp> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | low | CC: | jmadero.dev |
Version: | 4.3.5.2 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:4.5.0 target:4.4.1 | ||
i915 platform: | i915 features: |
Description
tmacalp
2015-01-09 16:14:36 UTC
Ubuntu 14.04 x64 LibreOffice 4.4.0.2 rc LibreOffice 4.3.5.2 release Confirmed on both, updating version to reflect oldest version tested on. Marking as: New Minor - can slow down professional quality work a little (maybe?) Low - default seems fine, workaround is easy (just click the x on the dialog) Interestingly though - when you close the dialog, the sidebar comes back :-/ Perhaps another bug report is needed for this (and ux-advise to figure out if that's expected). (In reply to Joel Madero from comment #1) > Interestingly though - when you close the dialog, the sidebar comes back :-/ > Perhaps another bug report is needed for this (and ux-advise to figure out > if that's expected). Yep, in step 3, I linked to bug 87217, which is the bug that describes that behavior--closing a floating sidebar by using the "X" window decoration reenables the normal sidebar instead of turning it off. IMO, that bug is MUCH more annoying. I can't see any justification for that being the expected behavior. Thanks for confirming/modifying. This one is rather minor, but would go a long way towards smoothing LO 4.4.0's transition to being forced to use the sidebar for Styles and Formatting. I've submitted a patch to gerrit for this issue: https://gerrit.libreoffice.org/#/c/13980/ My implementation tickles bug 87217 because I'm closing the undocked window the same way as clicking the X in the window decorations. Until that bug's behavior changes, my commit will simply reenable the docked sidebar when you attempt to dismiss the sidebar with another call to an item. Maybe it'd be more elegant if I could figure out how to toggle the sidebar the same way as either view->sidebar or sidebar_menu->close sidebar. Also, my patch is simply looking for a second call to an open category. As a side-effect, it will close the sidebar if you click on the same category button that's currently open. Ultimately, I should check to detect if the user clicked a category button or opened through other means, but I couldn't figure out how to elegantly implement it. Trent MacAlpine committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=592984cea1a9cc545358b8d6077113a658834aa5 fdo#88241 Floating sidebar second call to same item should dismiss it It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Trent MacAlpine committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7bb81cd93ad3a8d24cc69bc32ad22a5cbe1ec955&h=libreoffice-4-4 fdo#88241 Floating sidebar second call to same item should dismiss it It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.