Bug 88288

Summary: Memory leak in EnumerateActions call results handler (polkit_authority_enumerate_actions_finish)
Product: PolicyKit Reporter: Max A. Dednev <dednev>
Component: libpolkitAssignee: David Zeuthen (not reading bugmail) <zeuthen>
Status: RESOLVED FIXED QA Contact: David Zeuthen (not reading bugmail) <zeuthen>
Severity: major    
Priority: medium CC: dednev, simonandric5, walters
Version: unspecified   
Hardware: All   
OS: All   
i915 platform: i915 features:
Attachments: Fix for memory leak in EnumerateActions call results handler.

Description Max A. Dednev 2015-01-11 10:41:26 UTC
Created attachment 112087 [details]
Fix for memory leak in EnumerateActions call results handler.

I've found, that policykit-1-0.105 in my Debian Wheezy doesn't release reference counters of GVariant data for org.freedesktop.PolicyKit1.Authority.EnumerateActions DBUS call resulting data. 

See patch in attachment.
g_variant_ref_sink (child) call was odd in case of iterating array child items.
Comment 1 Max A. Dednev 2015-01-11 10:44:40 UTC
There is high possibility that this bug causes memory leaking in kded4 (see https://bugs.kde.org/show_bug.cgi?id=271934) and other policykit-1 client software.
Comment 2 Colin Walters 2015-01-12 01:04:37 UTC
Looks good to me, thanks!  I tweaked the commit message to match the standard style, and pushed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.