Bug 88362

Summary:	[PATCH] VPP: Fix Coverity alert on unitialized vpp_kernels
Product:	libva	Reporter:	Philippe "RzR" Coval <philippe.coval.pro>
Component:	intel	Assignee:	haihao <haihao.xiang>
Status:	RESOLVED FIXED	QA Contact:	Sean V Kelley <seanvk>
Severity:	normal
Priority:	medium	CC:	gb.devel
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-VPP-Fix-Coverity-alert-on-unitialized-vpp_kernels.patch

Description Philippe "RzR" Coval 2015-01-13 10:22:23 UTC

Hi,

Here is a simple minor patch to fix coverity “potential” security issues 
or at least the alert...

You'll found more detail on Tizen downstream bug report :

https://bugs.tizen.org/jira/browse/TC-2098

https://bugs.tizen.org/jira/secure/attachment/16184/libva_scan_01072015.pdf

There other alerts to be fixed but look like false positives to me
(I'll may send other patches to "flag" them if needed)

More to come on this bug report

Regards

Comment 1 Philippe "RzR" Coval 2015-01-13 10:32:26 UTC

Created attachment 112157 [details] [review]
0001-VPP-Fix-Coverity-alert-on-unitialized-vpp_kernels.patch

Here is the patch to review :

0001-VPP-Fix-Coverity-alert-on-unitialized-vpp_kernels.patch

Comment 2 haihao 2015-01-14 07:34:52 UTC

The driver never uses the unitialized variable as sharpening is only enabled on HSW+ . You can ignore it.

Comment 3 Philippe "RzR" Coval 2015-01-14 09:25:58 UTC

Yea I also thought author knews what they are doing but applying this patch will make make static analysis checkers happy

FYI. It was applied downstream in tizen project at 

https://review.tizen.org/gerrit/#/c/33632/

It may be skipped or updated in next version

Thanks for support, feel to close this bug if no activity after this message

Comment 4 haihao 2015-11-23 17:16:31 UTC

This issue was fixed in another way on master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.