| Summary: | [SNB+ Bisected]Ogles3conform ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels core dumped | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Tapani Pälli <lemody> |
| Status: | VERIFIED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | normal | ||
| Priority: | high | CC: | itoral, siglesias |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch to fix the issue
patch to fix the issue |
||
|
Description
lu hua
2015-01-14 02:42:25 UTC
I'll take a look at this We have GL_UNSIGNED_INT_2_10_10_10_REV and GL_RGB which is not handled by the switch there, but it wasn't even before the commit .. so changes in texstore.c are probably the guilty bits. Created attachment 112210 [details] [review] patch to fix the issue This fixes the issue, will do further testing to catch possible regressions. (In reply to Tapani Pälli from comment #3) > Created attachment 112210 [details] [review] [review] > patch to fix the issue > > This fixes the issue, will do further testing to catch possible regressions. Fixed by this patch. I'w working on a better fix now .. Created attachment 112332 [details] [review] patch to fix the issue new patch! CC Iago Comment on attachment 112332 [details] [review] patch to fix the issue Review of attachment 112332 [details] [review]: ----------------------------------------------------------------- ::: src/mesa/main/formats.c @@ +972,4 @@ > return; > > case MESA_FORMAT_B10G10R10A2_UNORM: > + case MESA_FORMAT_R10G10B10X2_UNORM: There is a "case MESA_FORMAT_B10G10R10X2_UNORM" a bit below, it is the same code, but maybe it makes more sense to move the "case MESA_FORMAT_R10G10B10X2_UNORM" down there so we keep formats with X bits together. @@ +1727,5 @@ > case MESA_FORMAT_A2R10G10B10_UNORM: > return format == GL_BGRA && type == GL_UNSIGNED_INT_10_10_10_2; > > + case MESA_FORMAT_R10G10B10X2_UNORM: > + return format == GL_RGB && type == GL_UNSIGNED_INT_2_10_10_10_REV; I think this might be wrong: looking at other formats with X bits in this same function, they all return FALSE... (In reply to Iago Toral from comment #8) > Comment on attachment 112332 [details] [review] [review] > patch to fix the issue > > Review of attachment 112332 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: src/mesa/main/formats.c > @@ +972,4 @@ > > return; > > > > case MESA_FORMAT_B10G10R10A2_UNORM: > > + case MESA_FORMAT_R10G10B10X2_UNORM: > > There is a "case MESA_FORMAT_B10G10R10X2_UNORM" a bit below, it is the same > code, but maybe it makes more sense to move the "case > MESA_FORMAT_R10G10B10X2_UNORM" down there so we keep formats with X bits > together. OK, will do > @@ +1727,5 @@ > > case MESA_FORMAT_A2R10G10B10_UNORM: > > return format == GL_BGRA && type == GL_UNSIGNED_INT_10_10_10_2; > > > > + case MESA_FORMAT_R10G10B10X2_UNORM: > > + return format == GL_RGB && type == GL_UNSIGNED_INT_2_10_10_10_REV; > > I think this might be wrong: looking at other formats with X bits in this > same function, they all return FALSE... True, thanks for a quick review, I'll send a fixed version to list! fixed in mesa master (since d74a817) Verified.Fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.