Bug 88561

Created attachment 112429 [details]
Good frame

Does the issue occur in any freely-available Steam game like Team Fortress 2 and DOTA 2? If not, could you please create an apitrace file reproducing the issue?

Created attachment 113176 [details]
Vertex issues in TF2

I've re-tested Portal with updated mesa (commit 2335153ff2fae01d6294876a86d3eab59c6c4236) and kernel (3.18.5-gentoo) and the issue is still there.

There also seems to be a rendering regression with TF2 for me, but it looks different. Where in Portal objects appear in front of others that they should be behind of, in TF 2 they disappear entirely or appear to have garbage vertices. I haven't yet tested that the TF2 issues were introduced in the same commit.

I'll create apitraces of both later today.

Here is an apitrace from portal that consistently triggers the bug for me (however, which frames are misrendered varies):

 http://constexpr.org/tmp/Portal-radeonsi.trace.xz (193 MiB)

For some reason this happens a lot less frequently now than it used to. With

Mesa git-8a71fd8
LLVM r229671
Kernel 3.19.0-gentoo

I need to re-run the apitrace multiple times before triggering the bug, while before there were many bad frames per run.

There are also other rendering errors in Portal that look more like the ones I get in TF2 - I guess those are more likely to be related to 88978.

I'm not sure what changed - the bug still happens infrequently when reverting to either Linux 3.18.6-gentoo or to Mesa git-2335153. Either way, the bug is still there, just a lot harder to reproduce now.

Created attachment 113659 [details] [review]
possible fix

Please test this patch. It seems to fix the bug for the apitrace.

(In reply to Marek Olšák from comment #6)
> Created attachment 113659 [details] [review] [review]
> possible fix
> 
> Please test this patch. It seems to fix the bug for the apitrace.

Thank you Marek.

Your patch fix this bug https://bugs.freedesktop.org/show_bug.cgi?id=88978 too.
Nice.

Hi Marek,

the patch does improve things a lot: with it I can no longer reproduce any glitches in my Portal trace or in the Dota 2 trace from bug 88978 comment 2. However, in-game some glitches remain.

In Portal they are extremely infrequent with your patch, however disappearing terrain patches and garbage vertices are still relatively easy to reproduce in Team Fortress 2. (Maybe this fits belongs in bug 88978?) I tried to record an apitrace of TF2 but it does not replay correctly. Just loading up a practice map (I tried Dustbowl) and walking around should be enough.

Created attachment 115651 [details]
Junk rendered in The Talos Principle

This still happens in various Source engine games (and perhaps elsewhere), just not as frequently.

The The Talos Principle trace from bug 87278 comment 29 has some garbage being rendered (screenshot attached) that looks similar to what I get in Source engine games, but it is much easier to reproduce:

 http://constexpr.org/tmp/Talos-radeonsi.3.trace.xz (147 MiB)

No idea of that is the same bug or even if the current Source engine issue is related to the original Portal bug I bisected in this bug.

I think Marek's patch fixed the original Portal issue I bisected in radeonsi. The remakning glitches seem to be caused by a LLVM regression. I've added the relevant information to bug #88978.