Bug 88573

Summary: [all Regression]igt/drv_module_reload doesn't reload module
Product: DRI Reporter: lu hua <huax.lu>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: high CC: intel-gfx-bugs
Version: unspecifiedKeywords: bisect_pending
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg none

Description lu hua 2015-01-19 08:02:29 UTC 
Created attachment 112448 [details]
dmesg

==System Environment==
--------------------------
Regression: Yes,igt
good commit: 329f7a3734331cb57895a675d4fc87c261f338bd
bad commit: 20d6e0f41b3b70a89946e5271bc4ffa7695be1b0

Non-working platforms: all

==kernel==
--------------------------
2015_01_05/drm-intel-nightly/07d0c831d9207c937595f081c8fddbddbf53756f
commit 07d0c831d9207c937595f081c8fddbddbf53756f
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Tue Dec 30 15:02:01 2014 +0200

    drm-intel-nightly: 2014y-12m-30d-13h-01m-34s UTC integration manifest


==Bug detailed description==
-----------------------------
module unloaded successfully, but it doesn't reload module.
It's igt regression. The return code is 0, and we reboot system after execute this case. So we didn't catch this issue, until I retest bug 88433.

output:
[root@x-hnr9 tests]# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon0/: (M) frame buffer device
module successfully unloaded
[root@x-hnr9 tests]# echo $?
0
[root@x-hnr9 tests]# ./drv_module_reload
 i915 debugfs path not found.

==Reproduce steps==
---------------------------- 
1. ./drv_module_reload
Comment 1 Chris Wilson 2015-01-19 09:47:52 UTC 
commit a29f28eba975388aed43c83dd6ed3ec2a869f4ce
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Jan 19 09:42:25 2015 +0000

    igt/drv_module_reload: Check more carefully for a live driver
    
    As drm_open_any() now quietly fails if there is no driver, this
    nullifies the effectiviness of using gem_exec_nop as the test for a good
    reload. Combine with gem_alive (and guarantee that gem_alive can detect
    a dead driver, putting lie to
    
    commit 032f30cb38bb03562ee7fde19cd278b1d8ac31a9
    Author: Thomas Wood <thomas.wood@intel.com>
    Date:   Tue Jan 13 13:33:57 2015 +0000
    
        lib: remove unnecessary checks on the drm_open_any return value
    
    ) first.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88573
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 2 lu hua 2015-01-20 07:26:50 UTC 
Verified.Fixed.
[root@x-hsw27 tests]# ./drv_module_reload
unbinding /sys/class/vtconsole/vtcon0/: (M) frame buffer device
module successfully unloaded
module successfully loaded again
Comment 3 Elizabeth 2017-10-06 14:32:12 UTC 
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.