Bug 88679

Summary: Simplify FC_FOUNDRY processing?
Product: fontconfig Reporter: Behdad Esfahbod <freedesktop>
Component: libraryAssignee: Akira TAGOH <akira>
Status: RESOLVED FIXED QA Contact: Behdad Esfahbod <freedesktop>
Severity: normal    
Priority: medium CC: akira, fontconfig-bugs, freedesktop
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Behdad Esfahbod 2015-01-21 21:52:43 UTC
According to MS website there are many many registered foundries:

http://www.microsoft.com/typography/links/vendorlist.aspx

I think we should simply set FC_FOUNDRY to the four-byte tag, not try to extend to full foundry name.

Means FcVendorFoundries can go away.  Probably also remove FcNoticeFoundry business.
Comment 1 Behdad Esfahbod 2015-01-21 22:07:08 UTC
*** Bug 88680 has been marked as a duplicate of this bug. ***
Comment 2 Akira TAGOH 2015-02-09 05:59:41 UTC
and how about adding another properties according to hour-byte tag in the configuration? is it maybe easier to maintain and extend as needed in each distros instead of updating the table and rebuild?
Comment 3 Akira TAGOH 2015-02-09 06:13:35 UTC
FcNoticeFoundry expects to see the non-four-byte tags. if we prefer to have four-byte tag as FC_FOUNDRY, we still maintain another table to convert it to four byte right?
Comment 4 Behdad Esfahbod 2015-02-28 02:28:08 UTC
I'd rather we simplify code.  I don't think anyone seriously uses this FC_FOUNDRY value, so regressing it is ok in my opinion.
Comment 5 Akira TAGOH 2015-04-20 02:50:30 UTC
just roughly googled FC_FOUNDRY and see how many customers use it. not sure how seriously changing the behavior of it affects to applications though, it will affects to UX at least since there are applications that uses it. we may need to do it carefully and slowly.
Comment 6 Behdad Esfahbod 2015-04-20 05:25:29 UTC
Can you list a few examples?  I have a hard time imagining existing users of this.
Comment 8 Behdad Esfahbod 2015-04-21 00:02:53 UTC
My gut feeling is that no one will notice. :D
Comment 9 Akira TAGOH 2015-04-21 08:23:31 UTC
Getting rid of FcNoticeFoundry seems not a good idea. in case it is used in the code path, the foundry looks like:
  foundry: "Copyright (c) 1989, 1991 Adobe Systems Incorporated.  All Rights Reserved.Utopia is a registered trademark of Adobe Systems Incorporated."(s)

it isn't what we expect.
Comment 10 Behdad Esfahbod 2015-04-21 18:24:21 UTC
(In reply to Akira TAGOH from comment #9)
> Getting rid of FcNoticeFoundry seems not a good idea. in case it is used in
> the code path, the foundry looks like:
>   foundry: "Copyright (c) 1989, 1991 Adobe Systems Incorporated.  All Rights
> Reserved.Utopia is a registered trademark of Adobe Systems Incorporated."(s)
> 
> it isn't what we expect.

Humm.  I thought it looks for strings like Adobe and assigns "Adobe"...
Comment 11 Akira TAGOH 2015-04-22 02:31:18 UTC
(In reply to Behdad Esfahbod from comment #10)
> (In reply to Akira TAGOH from comment #9)
> > Getting rid of FcNoticeFoundry seems not a good idea. in case it is used in
> > the code path, the foundry looks like:
> >   foundry: "Copyright (c) 1989, 1991 Adobe Systems Incorporated.  All Rights
> > Reserved.Utopia is a registered trademark of Adobe Systems Incorporated."(s)
> > 
> > it isn't what we expect.
> 
> Humm.  I thought it looks for strings like Adobe and assigns "Adobe"...

right. so FcNoticeFoundry assigns "Adobe" instead of the above copyright notice in that case. let me show you some examples we fail on picking up foundries without FcNoticeFoundry. there are two code paths acquire the information through FcNoticeFoundry. one is from TT_NAME_ID_{TRADEMARK,MANUFACTURE} and one is FT_Get_PS_Font_Info.
the former one fails on google-crosextra-caladea and lyx say. later one is Type1 fonts and some PCF fonts. apparently we need to keep maintaining FcNoticeFoundry at least for them.
Comment 12 Akira TAGOH 2015-04-22 03:56:34 UTC
(In reply to Akira TAGOH from comment #11)
> the former one fails on google-crosextra-caladea and lyx say.

Oh, wait. this isn't true. those has "unknown" even now.
Comment 13 Akira TAGOH 2015-04-22 05:38:23 UTC
proposed changes here:
  http://cgit.freedesktop.org/~tagoh/fontconfig/commit/?h=bz88679
Comment 14 Behdad Esfahbod 2015-04-22 05:57:23 UTC
Looks good to me.  Please send a note to the list after you push this out, so we know if people rely on it.

I remember SuSE used to prepend foundry to family name, mostly to differentiate various Fixed bitmap fonts IIRC.
Comment 15 Akira TAGOH 2015-04-22 09:41:00 UTC
committed into git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.