| Summary: | nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | mesa-dev |
| Severity: | blocker | ||
| Priority: | medium | CC: | cwabbott0, jason |
| Version: | git | Keywords: | bisected, regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | FreeBSD | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
89285e4d47a65e52547180dca46ecfd81b2996e9 is the first bad commit commit 89285e4d47a65e52547180dca46ecfd81b2996e9 Author: Jason Ekstrand <jason.ekstrand@intel.com> Date: Fri Jan 23 13:38:46 2015 -0800 nir: add new constant folding infrastructure Add a required field to the Opcode class, const_expr, that contains an expression or statement that computes the result of the opcode given known constant inputs. Then take those const_expr's and expand them into a function that takes an opcode and an array of constant inputs and spits out the constant result. This means that when adding opcodes, there's one less place to update, and almost all the opcodes are self-documenting since the information on how to compute the result is right next to the definition. The helper functions in nir_constant_expressions.c were taken from ir_constant_expressions.cpp. v3 Jason Ekstrand <jason.ekstrand@iastate.edu> - Use mako to generate one function per opcode instead of doing piles of string splicing v4 Jason Ekstrand <jason.ekstrand@iastate.edu> - More comments and better indentation in the mako - Add a description of the constant expression language in nir_opcodes.py - Added nir_constant_expressions.py to EXTRA_DIST in Makefile.am Signed-off-by: Jason Ekstrand <jason.ekstrand@intel.com> Reviewed-by: Connor Abbott <cwabbott0@gmail.com> :040000 040000 4823f33d8c6840f25c1aefc6c61cec212492c805 5d152f618ce5fe346a0e71f4be242b597120a219 M src bisect run success I just sent two patches to the list that should fix this. Could you please try this branch and see if it works: http://cgit.freedesktop.org/~jekstrand/mesa/log/?h=fpclassify This should be fixed in master. Reopen if it's not. mesa: 58e8468d113c7d3d4a59ea4a8d70fd45b78e85e6 (10.5.0-devel)
CC nir/nir_constant_expressions.lo
nir/nir_constant_expressions.c:2754:16: error: controlling expression type 'unsigned int' not compatible with any
generic association type
if (fpclassify(dst) != FP_NORMAL)
^~~
/usr/include/math.h:114:19: note: expanded from macro 'fpclassify'
__fp_type_select(x, __fpclassifyf, __fpclassifyd, __fpclassifyl)
^
/usr/include/math.h:86:49: note: expanded from macro '__fp_type_select'
#define __fp_type_select(x, f, d, ld) _Generic((x), \
^
What's the status of this bug. I thought it'd been fixed. mesa: 627c68308683abbd6e563a09af6013a33938a790 (master 10.6.0-devel) The build error doesn't occur anymore. Then let's close this |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
mesa: 9cbb9165b9454ccc7f2a6702ce71bc5cd9faba02 (master 10.5.0-devel) CC nir/nir_constant_expressions.lo nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type if (!isnormal(dst)) ^~~ /usr/include/math.h:119:38: note: expanded from macro 'isnormal' #define isnormal(x) __fp_type_select(x, __isnormalf, __isnormal, __isnormall) ^ /usr/include/math.h:86:49: note: expanded from macro '__fp_type_select' #define __fp_type_select(x, f, d, ld) _Generic((x), \ ^