Bug 88906

Summary: [BDW Bisected]Ogles3conform ES3-CTS.shaders.uniform_block.random.nested_structs_arrays_instance_arrays.9 fails
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i965Assignee: Matt Turner <mattst88>
Status: VERIFIED DUPLICATE QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium CC: idr
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description lu hua 2015-02-02 03:07:05 UTC 
System Environment:
--------------------------
Platform: BDW
Libdrm:		(master)libdrm-2.4.59-6-g28ee135a37e10b9a6cd62d67df0332e38ee0b85c
Mesa:		(master)6094619c0297180db218e5b4e45fc07aff116413
Xserver:	(master)xorg-server-1.16.99.902-4-g697b696e5e24d0679f133183a3bb0852025377c2
Xf86_video_intel:(master)2.99.917-75-g6d2754b1902e8bce37818c854fb890400b27343e
Libva:		(master)f9741725839ea144e9a6a1827f74503ee39946c3
Libva_intel_driver:(master)bf324e3440246a487997a1624ac862e3e4027f9e
Kernel:   (drm-intel-nightly)8b4216f91c7bf8d3459cadf9480116220bd6545e

Bug detailed description:
---------------------------
It fails on BDW with mesa master branch when run automation testing, but I am not able reproduce it manually. In automation testing, the good commit is adc8cdfa351240f1ce28b677e1be79a30a36b594. 

output(manually):
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
  target implementation = 'X11'
libGL: Error in /etc/drirc line 1, column 0: no element found.
libGL: Error in /root/.drirc line 1, column 0: no element found.
libGL: Error in /etc/drirc line 1, column 0: no element found.
libGL: Error in /root/.drirc line 1, column 0: no element found.

Test case 'ES3-CTS.shaders.uniform_block.random.nested_structs_arrays_instance_arrays.9'..
Vertex compile time = 5.927000 ms
Fragment compile time = 4.195000 ms
Link time = 47.992001 ms
  Pass (Pass)

DONE!

Test run totals:
  Passed:        1/1 (100.00%)
  Failed:        0/1 (0.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)

automation test log:
Output:
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
  target implementation = 'X11'

Test case 'ES3-CTS.shaders.uniform_block.random.nested_structs_arrays_instance_arrays.9'..
Vertex compile time = 7.408000 ms
Fragment compile time = 4.233000 ms
Link time = 141.953995 ms
  Fail (Image compare failed)

DONE!

Test run totals:
  Passed:        0/1 (0.00%)
  Failed:        1/1 (100.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)

returncode: 0
result: fail
summary: Ogles3conform/ES3-CTS.shaders.uniform_block.random.nested_structs_arrays_instance_arrays.9    FAIL

Reproduce steps:
-------------------------
1. xinit
2. run full Ogles3conform cases
Comment 1 Ian Romanick 2015-02-11 22:28:11 UTC 
Can you narrow the range at all?  There are 194 commits between adc8cdf and 6094619. :(
Comment 2 lu hua 2015-02-12 03:35:30 UTC 
Run binary, it always pass, run this case via infrastructure, I can reproduce the fail. Bisected it.
Bisect shows: c638ea3d19d46cfe65739af2c78373146ed50737 is the first bad commit
commit c638ea3d19d46cfe65739af2c78373146ed50737
Author:     Matt Turner <mattst88@gmail.com>
AuthorDate: Wed Apr 9 13:38:14 2014 -0700
Commit:     Matt Turner <mattst88@gmail.com>
CommitDate: Fri Jan 23 17:57:39 2015 -0800

    i965: Don't make instructions with a null dest a barrier to scheduling.

    Now that we properly track accumulator dependencies, the scheduler is
    able to schedule instructions between the mach and mov in the common
    the integer multiplication pattern:

       mul  acc0, x, y
       mach null, x, y
       mov  dest, acc0

    Since a null destination implies no dependency on the destination, we
    can also safely schedule instructions (that don't write the accumulator)
    between the mul and mach.

    GAINED:                                103
    LOST:                                  43

    Causes one program to spill (643 -> 1076 instructions).

    I committed this patch last year (commit 42a26cb5) but reverted it
    (commit 0d3f83f4) after inexplicable artifacts in Kerbal Space Program
    (bug 78648). Tapani reapplied this patch and could not reproduce the bug
    with current Mesa.

    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Jason Ekstrand <jason.ekstrand@intel.com>
Comment 3 lu hua 2015-02-12 04:54:43 UTC 

*** This bug has been marked as a duplicate of bug 88793 ***
Comment 4 Matt Turner 2015-02-12 07:20:12 UTC 
(In reply to lu hua from comment #2)
> Run binary, it always pass, run this case via infrastructure, I can
> reproduce the fail. Bisected it.

For what it's worth, I tried reproducing this as well (since the failing testes in bug 88793 are full of spilling) and could not.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.