Bug 88932

Summary: libzeitgeist-internal.la and libzeitgeist-internal.la need -fPIC
Product: Zeitgeist Reporter: Ting-Wei Lan <lantw44>
Component: libzeitgeistAssignee: zeitgeist-bugs <zeitgeist-bugs>
Status: RESOLVED FIXED QA Contact: zeitgeist-bugs <zeitgeist-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: FreeBSD   
Whiteboard:
i915 platform: i915 features:
Attachments: [PATCH] Add -fPIC to libzeitgeist-internal.la and libzeitgeist_datamodel-2.0.la

Description Ting-Wei Lan 2015-02-03 06:30:42 UTC
Created attachment 113085 [details]
[PATCH] Add -fPIC to libzeitgeist-internal.la and libzeitgeist_datamodel-2.0.la

Both libzeitgeist-internal.la and libzeitgeist_datamodel-2.0.la are used to build libzeitgeist-2.0.la, which will be used as a shared library. Not using -fPIC causes build failure.
Comment 1 Ting-Wei Lan 2015-03-05 17:53:03 UTC
Can anyone review the patch?
Comment 2 Rico Tzschichholz 2015-06-27 20:47:21 UTC
commit 99f196775b0f685e912bd0dc615c2e10d9a927c7
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date:   Tue Feb 3 03:23:40 2015 +0800

    Add -fPIC to libzeitgeist-internal.la and libzeitgeist_datamodel-2.0.la
    
    It is needed because libzeitgeist-2.0.la is used as a shared library, which
    requires all dependencies be built as PIC.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=88932

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.