Bug 88952

Summary: Remove the unused "auto_connect" parameter from module-bluez4-device
Product: PulseAudio Reporter: Tanu Kaskinen <tanuk>
Component: modulesAssignee: Manish <manish.sogi>
Status: RESOLVED FIXED QA Contact: pulseaudio-bugs
Severity: normal    
Priority: medium CC: lennart
Version: unspecifiedKeywords: love
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Tanu Kaskinen 2015-02-03 21:48:17 UTC
The "auto_connect" module parameter is not used in module-bluez4-device, so it can be removed.
Comment 1 Manish 2015-06-26 05:00:19 UTC
http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-June/024085.html

Signed-off-by: Manish Sogi <manish.sogi at samsung.com>

---
 src/modules/bluetooth/module-bluez4-device.c |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/modules/bluetooth/module-bluez4-device.c b/src/modules/bluetooth/module-bluez4-device.c
index db69d34..a23c2a9 100644
--- a/src/modules/bluetooth/module-bluez4-device.c
+++ b/src/modules/bluetooth/module-bluez4-device.c
@@ -75,7 +75,6 @@ PA_MODULE_USAGE(
         "rate=<sample rate> "
         "channels=<number of channels> "
         "path=<device object path> "
-        "auto_connect=<automatically connect?> "
         "sco_sink=<SCO over PCM sink name> "
         "sco_source=<SCO over PCM source name>");
 
@@ -94,7 +93,6 @@ static const char* const valid_modargs[] = {
     "rate",
     "channels",
     "path",
-    "auto_connect",
     "sco_sink",
     "sco_source",
     NULL
@@ -148,7 +146,6 @@ struct userdata {
     pa_hook_slot *transport_speaker_changed_slot;
 
     pa_bluez4_discovery *discovery;
-    bool auto_connect;
 
     char *output_port_name;
     char *input_port_name;
@@ -2460,12 +2457,6 @@ int pa__init(pa_module *m) {
         goto fail;
     }
 
-    u->auto_connect = true;
-    if (pa_modargs_get_value_boolean(ma, "auto_connect", &u->auto_connect)) {
-        pa_log("Failed to parse auto_connect= argument");
-        goto fail;
-    }
-
     channels = u->sample_spec.channels;
     if (pa_modargs_get_value_u32(ma, "channels", &channels) < 0 ||
         !pa_channels_valid(channels)) {
-- 
1.7.9.5
Comment 2 Tanu Kaskinen 2015-09-17 14:24:36 UTC
Patch applied.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.