Bug 89148

Note that the texture is never used as a source or destination in a regular draw. It is specified with glTexImage2D, but the data pointer is NULL, and glTexSubImage2D is never used. It is only filled with data through the FBO_blit call that resolves the multisampled renderbuffer. As far as I can see no PBO is used.

Type 1 packets shouldn't be emitted at all and none of the user mode drivers emit them.  I suspect either the command stream is getting corrupted somewhere or there is a prior packet count getting set wrong.

My semi-educated guess would be that the multisample resolve blit sets the size wrong. That would explain why out of the many glGetTexImage calls we're doing this is the only one that fails.

Time to write a stand-alone test case I guess.

Created attachment 113562 [details]
Test program

This program reproduces the result. As a 32 bit binary it generates the same type 1 command that is rejected. As a 64 bit program it crashes with the following backtrace:

(gdb) bt
#0  0x00007ffff75c8c90 in ?? () from /lib64/libc.so.6
#1  0x00007ffff2e0bcd3 in memcpy (__len=32, __src=<optimized out>, __dest=<optimized out>) at /usr/include/bits/string3.h:51
#2  r300_emit_blend_state (r300=<optimized out>, size=8, state=<optimized out>) at r300_emit.c:57
#3  0x00007ffff2e0f150 in r300_emit_dirty_state (r300=r300@entry=0x649950) at r300_emit.c:1450
#4  0x00007ffff2e12018 in r300_emit_states (instance_id=-1, index_bias=0, buffer_offset=0, index_buffer=0x0, flags=<optimized out>, r300=0x649950) at r300_render.c:259
#5  r300_prepare_for_rendering (r300=r300@entry=0x649950, flags=<optimized out>, flags@entry=PREP_EMIT_STATES, index_buffer=index_buffer@entry=0x0, cs_dwords=cs_dwords@entry=21, buffer_offset=buffer_offset@entry=0, index_bias=index_bias@entry=0, 
    instance_id=instance_id@entry=-1) at r300_render.c:311
#6  0x00007ffff2e13258 in r300_blitter_draw_rectangle (blitter=<optimized out>, x1=0, y1=0, x2=256, y2=256, depth=0, type=UTIL_BLITTER_ATTRIB_NONE, attrib=0x0) at r300_render.c:1141
#7  0x00007ffff2d7d3df in util_blitter_custom_color (blitter=0x61c7f0, dstsurf=dstsurf@entry=0x79e030, custom_blend=custom_blend@entry=0x0) at util/u_blitter.c:2146
#8  0x00007ffff2e06b91 in r300_simple_msaa_resolve (pipe=pipe@entry=0x649950, dst=dst@entry=0x79dcd0, dst_level=dst_level@entry=0, dst_layer=dst_layer@entry=0, src=<optimized out>, format=PIPE_FORMAT_B8G8R8A8_SRGB) at r300_blit.c:737
#9  0x00007ffff2e08396 in r300_msaa_resolve (info=0x7ffffffbdc70, pipe=0x649950) at r300_blit.c:783
#10 r300_blit (pipe=0x649950, blit=<optimized out>) at r300_blit.c:809
#11 0x00007ffff2c2ad97 in st_BlitFramebuffer (ctx=<optimized out>, readFB=0x796f30, drawFB=0x79d6b0, srcX0=<optimized out>, srcY0=<optimized out>, srcX1=<optimized out>, srcY1=256, dstX0=0, dstY0=0, dstX1=256, dstY1=256, mask=16384, filter=9728)
    at state_tracker/st_cb_blit.c:263
#12 0x00007ffff2af2ff2 in _mesa_BlitFramebuffer (srcX0=<optimized out>, srcY0=0, srcX1=<optimized out>, srcY1=256, dstX0=<optimized out>, dstY0=<optimized out>, dstX1=256, dstY1=256, mask=16384, filter=9728) at main/blit.c:509
#13 0x000000000040132f in init ()
#14 0x000000000040148a in main ()

Further testing shows that the GL_SRGB8_ALPHA8 internal format of the destination texture is the problem. Replacing this with GL_RGBA8 makes the test work fine. Note that when GL_EXT_sRGB_decode is available Wine always creates sRGB textures and sets GL_TEXTURE_SRGB_DECODE_EXT to GL_SKIP_DECODE_EXT to get d3d-style sRGB read correction toggling.

Created attachment 113620 [details] [review]
add some debugging output

Can you apply this kernel patch and attach your kernel log output when you hit the error?

Created attachment 113719 [details] [review]
workaround

Can you test this patch? Note that GL_ARB_framebuffer_sRGB is unsupported.

I'll try it in the next two days. If the workaround doesn't work I'll try to get the log Alex asked for.

I'm pretty sure the CS parser errors were caused by random garbage emitted by r300g. The driver doesn't expect an sRGB format in the framebuffer, which only seems to happen with glBlitFramebuffer.

No more segfaults, but it still has a rejected CS:

[129870.605179] [drm:r100_cs_track_check] *ERROR* [drm] Buffer too small for color buffer 0 (need 8387584 have 524288) !
[129870.605186] [drm:r100_cs_track_check] *ERROR* [drm] color buffer 0 (16382 2 0 256)
[129870.605189] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !

Created attachment 113802 [details] [review]
fix

This patch should fix it.

Attachment 113802 [details] fixes the invalid CS / crash and my test program now reads a color. However, sRGB color correction seems to be applied at some stage. Note that the test program is not using GL_ARB_framebuffer_sRGB (which isn't supported on r500 anyway), and that GL_TEXTURE_SRGB_DECODE_EXT is set to GL_SKIP_DECODE_EXT.

It seems that the correction is applied during blitting. If I clear the 2D texture directly the expected result (0x0000ff80) is returned. If I use the renderbuffer and blit I get 0x0000ff37.

(Wine expects that glBlitFramebuffer never applies sRGB correction when blitting from an sRGB texture, but this codepath is only used if GL_EXT_sRGB_decode is not supported. In this case we load two copies of the texture, one sRGB and one RGB, and use glBlitFramebuffer to blit between them if the application toggles sRGB on and off.)

r300g doesn't do sRGB conversion for MSAA resolves. It always interprets the textures as linear and only averages the samples.

The thing that seems to trigger the sRGB correction is the fact that the destination texture has an sRGB internal. If I change it to GL_RGBA8 I get the expected result.

The format of the source RB doesn't seem to matter here.

Fixed by 9953586af2254f83a610d4cd284f52f37fa18b98 and c939231e7223510408a446400ad23b8b5ce2922e. My test program returns the correct color and the Wine test passes. Thanks!