Bug 89472

Summary:	Sometimes "password-hint" is replaced by user real name
Product:	accountsservice	Reporter:	Juan A. Suarez <jasuarez>
Component:	general	Assignee:	Matthias Clasen <mclasen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	jasuarez, marius.vollmer, rstrode, stefw
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	lib: Copy "password-hint" instead of user's real name systemd: make sure to only start plymouth is started

Description Juan A. Suarez 2015-03-06 16:05:46 UTC

This is something that is not easy to reproduce, but working in a gnome-control-center fork that shows password-hint in the password dialog (calling act_user_get_password_hint() ), sometimes instead the user real name is returned instead.

Taking a look at the code, this happens when _act_user_load_from_user() is invoked. Turns out that in this code, we get rid of the old user password-hint, and instead of using the password-hint of the new user, we use it's real name.

I don't know if this is done on purpose (due some sort of security problem), or is rather a bug, because as far as I understand "user" and "user_to_copy" are the actually the same user. So copying the password-hint value shouldn't be a problem.

Comment 1 Juan A. Suarez 2015-03-06 16:08:17 UTC

Created attachment 114091 [details] [review]
lib: Copy "password-hint" instead of user's real name

Comment 2 Ray Strode [halfline] 2015-03-06 20:26:48 UTC

yea clearly just a bug, not by design

Comment 3 Ray Strode [halfline] 2015-03-06 20:27:25 UTC

Attachment 114091 [details] pushed as 9d16bc4 - lib: Copy "password-hint" instead of user's real name

Comment 4 Ray Strode [halfline] 2015-03-06 20:38:37 UTC

Created attachment 114096 [details] [review]
systemd: make sure to only start plymouth is started

This commit makes sure gdm doesn't start in parallel with plymouth,
which could lead to plymouth activating after X is started.

Furthermore, GDM is replacing getty@tty1.service and
plymouth-quit.service, so it needs to have the same dependencies
as them.

Comment 5 Ray Strode [halfline] 2015-03-06 20:39:20 UTC

(ignore that last patch, wrong bug)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.