Bug 89515

Summary:	undefined reference to `PA_CLAMP_UNLIKELY'
Product:	PulseAudio	Reporter:	Victor Toso <bugzilla>
Component:	clients	Assignee:	pulseaudio-bugs
Status:	RESOLVED MOVED	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	Other
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	move PA_UNLIKELY() from pulsecore/macro.h to pulse/gccmacro.h

Description Victor Toso 2015-03-10 13:12:06 UTC

Can't use PA_CLAMP_VOLUME defined in volume.h as it uses PA_CLAMP_UNLIKELY which is not defined in any header.

System: Fedora 21
$rpm -ql pulseaudio-libs-devel-5.0-25.fc21.x86_64 | grep -i include
/usr/include/pulse
/usr/include/pulse/cdecl.h
/usr/include/pulse/channelmap.h
/usr/include/pulse/context.h
/usr/include/pulse/def.h
/usr/include/pulse/error.h
/usr/include/pulse/ext-device-manager.h
/usr/include/pulse/ext-device-restore.h
/usr/include/pulse/ext-stream-restore.h
/usr/include/pulse/format.h
/usr/include/pulse/gccmacro.h
/usr/include/pulse/glib-mainloop.h
/usr/include/pulse/introspect.h
/usr/include/pulse/mainloop-api.h
/usr/include/pulse/mainloop-signal.h
/usr/include/pulse/mainloop.h
/usr/include/pulse/operation.h
/usr/include/pulse/proplist.h
/usr/include/pulse/pulseaudio.h
/usr/include/pulse/rtclock.h
/usr/include/pulse/sample.h
/usr/include/pulse/scache.h
/usr/include/pulse/simple.h
/usr/include/pulse/stream.h
/usr/include/pulse/subscribe.h
/usr/include/pulse/thread-mainloop.h
/usr/include/pulse/timeval.h
/usr/include/pulse/utf8.h
/usr/include/pulse/util.h
/usr/include/pulse/version.h
/usr/include/pulse/volume.h
/usr/include/pulse/xmalloc.h

Comment 1 Raymond 2015-03-11 10:11:26 UTC

http://cgit.freedesktop.org/pulseaudio/pulseaudio/tree/src/pulsecore/macro.h

Comment 2 Peter Meerwald 2015-05-20 20:45:41 UTC

Created attachment 115931 [details] [review]
move PA_UNLIKELY() from pulsecore/macro.h to pulse/gccmacro.h

PA_CLAMP_VOLUME() in pulse/volume.h makes use of PA_CLAMP_UNLIKELY(), but PA_CLAMP_UNLIKELY() is #defined in pulsecore/macro.h, hence to avoidable to users of libpulse

proposed solution moves PA_CLAMP_UNLIKELY() together with PA_UNLIKELY() to pulse/gccmacro.h which is public

Comment 3 GitLab Migration User 2018-07-30 10:07:30 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/216.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.