Bug 89599

Ping anyone ?

This patch fixes this issues:

https://abf.io/openmandriva/mesa/blob/master/mesa-10.5.2-hide-few-symbols-to-workaround-clang.patch

Can we land this?

Created attachment 115318 [details] [review]
Potential fix

The patch should be sent to the mailing list.

What do I have to do to reproduce this? Mesa builds with clang (3.7.0)
fine for me. I've built with clang occasionally for a few years and
have never encountered this problem.

(In reply to Matt Turner from comment #6)
> What do I have to do to reproduce this? Mesa builds with clang (3.7.0)
> fine for me. I've built with clang occasionally for a few years and
> have never encountered this problem.

I use: CC=clang CXX="clang++ -std=libc++" CFLAGS="-march=sandybridge -g -Ofast -pipe -fstack-protector-strong", same CXXFLAGS.

This is clang 3.8.0 svn snapshot from 2 days ago. -Ofast doesn't matter here. Might be the march setting turning on something that causes the problem.

I've build mesa-11.1.1 without a patch from comment #2.

make[4]: Entering directory '/builddir/build/BUILD/mesa-11.1.1/src/mapi'
/bin/sh ../../libtool  --tag=CC   --mode=link /usr/bin/clang -pthread -Werror=pointer-arith -Werror=vla -Oz -gdwarf-4 -Wstrict-aliasing=2 -pipe  -D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4  -fPIC -flto -fno-optimize-sibling-calls -Ofast -Wall -std=c99 -Werror=implicit-function-declaration -Werror=missing-prototypes -fno-strict-aliasing -fno-math-errno -fno-trapping-math -fno-builtin-memcmp -Qunused-arguments  -no-undefined -Wl,--gc-sections -Wl,--no-undefined -Oz -gdwarf-4 -Wstrict-aliasing=2 -pipe  -D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4  -fPIC -flto -Wl,-O2  -flto  -o shared-glapi/libglapi.la -rpath /usr/lib64 shared_glapi_libglapi_la-entry.lo shared_glapi_libglapi_la-mapi_glapi.lo shared_glapi_libglapi_la-stub.lo shared_glapi_libglapi_la-table.lo shared_glapi_libglapi_la-u_current.lo shared_glapi_libglapi_la-u_execmem.lo -lpthread  
libtool: link: /usr/bin/clang -shared  -fPIC -DPIC  .libs/shared_glapi_libglapi_la-entry.o .libs/shared_glapi_libglapi_la-mapi_glapi.o .libs/shared_glapi_libglapi_la-stub.o .libs/shared_glapi_libglapi_la-table.o .libs/shared_glapi_libglapi_la-u_current.o .libs/shared_glapi_libglapi_la-u_execmem.o   -lpthread  -pthread -Oz -gdwarf-4 -fstack-protector -flto -Ofast -Wl,--gc-sections -Wl,--no-undefined -Oz -gdwarf-4 -fstack-protector -flto -Wl,-O2 -flto   -pthread -Wl,-soname -Wl,libglapi.so.0 -o shared-glapi/.libs/libglapi.so.0.0.0
Makefile:1226: recipe for target 'shared-glapi/libglapi.la' failed
make[4]: Leaving directory '/builddir/build/BUILD/mesa-11.1.1/src/mapi'
LLVM ERROR: symbol 'x86_64_entry_start' is already defined
clang-3.7: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [shared-glapi/libglapi.la] Error 1
make[4]: *** Waiting for unfinished jobs....

Full build log:
https://abf.io/build_lists/2620585

(In reply to Matt Turner from comment #6)
> What do I have to do to reproduce this? Mesa builds with clang (3.7.0)
> fine for me. I've built with clang occasionally for a few years and
> have never encountered this problem.

I can also reproduce this build error with clang.

./autogen.sh --enable-glx-tls --with-dri-drivers= --with-gallium-drivers=swrast

*** Bug 92630 has been marked as a duplicate of this bug. ***

I sent a modified version of Tomasz's patch last week to mesa-dev.

Would anyone like to test it?

[PATCH] mapi: Massage code to allow clang to compile.

(In reply to Matt Turner from comment #11)
> I sent a modified version of Tomasz's patch last week to mesa-dev.
> 
> Would anyone like to test it?
> 
> [PATCH] mapi: Massage code to allow clang to compile.

https://lists.freedesktop.org/archives/mesa-dev/2016-July/122804.html works for me, with mesa 11.0.6 and clang 3.7.1.

Thanks all. I've pushed the patch:

commit 5ec140c17b54c25920091501b665b9aa809cc5e8
Author: Matt Turner <mattst88@gmail.com>
Date:   Mon Jul 11 10:44:25 2016 -0700

    mapi: Massage code to allow clang to compile.

(In reply to Matt Turner from comment #11)
> I sent a modified version of Tomasz's patch last week to mesa-dev.
> 
> Would anyone like to test it?
> 
> [PATCH] mapi: Massage code to allow clang to compile.

Thanks for this patch. It work fine with LLVM/clang-3.8.1 !