Bug 89629

Summary: [i965 regression]igt/kms_rotation_crc/sprite-rotation causes WARNING: CPU: 0 PID: 4126 at drivers/gpu/drm/drm_irq.c:1133 drm_wait_one_vblank+0x3b/0x16d [drm]()
Product: DRI Reporter: lu hua <huax.lu>
Component: DRM/IntelAssignee: Carlos Santa <carlos.santa>
Status: CLOSED INVALID QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: adrian.sandu, christophe.prigent, intel-gfx-bugs
Version: unspecifiedKeywords: bisect_pending, regression
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: I965G i915 features: display/Other
Attachments:
Description Flags
dmesg none

Description lu hua 2015-03-18 06:10:53 UTC
Created attachment 114418 [details]
dmesg

==System Environment==
--------------------------
Regression:  yes
good commit:fd2d61341bf39d1054256c07d6eddd624ebc4241(result id/hsw24:276719403)
bad commit: e0860aeed3980d1f7b564e1b5cf51ea26740542f(result id/hsw24:282181063)


no-working platforms: i965 platforms.

==kernel==
--------------------------
drm-intel-nightly/3753ea527e539d3358a6368e77cb29ecb2e71c42
commit 3753ea527e539d3358a6368e77cb29ecb2e71c42
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Mar 17 22:36:04 2015 +0100

    drm-intel-nightly: 2015y-03m-17d-21h-35m-20s UTC integration manifest

==Bug detailed description==
-----------------------------
It cases warning WARNING: CPU: 0 PID: 4152 at drivers/gpu/drm/drm_irq.c:1133 drm_wait_one_vblank+0x3b/0x16d [drm]().

output:
IGT-Version: 1.10-g505645c (x86_64) (Linux: 4.0.0-rc4_drm-intel-nightly_3753ea_20150318+ x86_64)
Subtest sprite-rotation: SUCCESS (1.880s)

dmesg:
[  121.774625] ------------[ cut here ]------------
[  121.774636] WARNING: CPU: 0 PID: 4152 at drivers/gpu/drm/drm_irq.c:1133 drm_wait_one_vblank+0x3b/0x16d [drm]()
[  121.774637] vblank not available on crtc 0, ret=-22
[  121.774638] Modules linked in: dm_mod iTCO_wdt iTCO_vendor_support snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic serio_raw pcspkr i2c_i801 lpc_ich mfd_core snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore battery wmi tpm_infineon tpm_tis tpm acpi_cpufreq i915 button video drm_kms_helper drm
[  121.774649] CPU: 0 PID: 4152 Comm: kms_rotation_cr Not tainted 4.0.0-rc4_drm-intel-nightly_3753ea_20150318+ #60
[  121.774650] Hardware name: ASUS All Series/Z87-EXPERT, BIOS 1008 05/17/2013
[  121.774651]  0000000000000000 0000000000000009 ffffffff817942e1 ffff88025235fa38
[  121.774653]  ffffffff8103bd5a 0000000000000000 ffffffffa0005f43 0000000000000000
[  121.774654]  ffff880256765000 0000000000000000 ffff88025676c000 ffffffffa010c7d0
[  121.774656] Call Trace:
[  121.774659]  [<ffffffff817942e1>] ? dump_stack+0x40/0x50
[  121.774663]  [<ffffffff8103bd5a>] ? warn_slowpath_common+0x98/0xb0
[  121.774667]  [<ffffffffa0005f43>] ? drm_wait_one_vblank+0x3b/0x16d [drm]
[  121.774669]  [<ffffffff8103bdb7>] ? warn_slowpath_fmt+0x45/0x4a
[  121.774672]  [<ffffffffa0005f43>] ? drm_wait_one_vblank+0x3b/0x16d [drm]
[  121.774676]  [<ffffffff813f14b4>] ? __pm_runtime_resume+0x5b/0x6a
[  121.774689]  [<ffffffffa00c39f1>] ? intel_finish_crtc_commit+0x47/0x10b [i915]
[  121.774692]  [<ffffffffa005290d>] ? drm_plane_helper_commit+0x16c/0x224 [drm_kms_helper]
[  121.774695]  [<ffffffff810e5128>] ? kmemdup+0x18/0x2c
[  121.774704]  [<ffffffffa00cdc8b>] ? __intel_set_mode+0x313/0x8bd [i915]
[  121.774712]  [<ffffffffa00d3bea>] ? intel_crtc_set_config+0x89a/0xbaa [i915]
[  121.774714]  [<ffffffff81060b23>] ? pick_next_task_fair+0x1f5/0x3dc
[  121.774716]  [<ffffffff81798083>] ? __ww_mutex_lock+0x15/0x86
[  121.774721]  [<ffffffffa0018023>] ? drm_modeset_lock+0x4e/0xa3 [drm]
[  121.774725]  [<ffffffffa00183a4>] ? drm_modeset_lock_all_crtcs+0x69/0x81 [drm]
[  121.774730]  [<ffffffffa000c1e7>] ? drm_mode_set_config_internal+0x4e/0xd2 [drm]
[  121.774734]  [<ffffffffa000cabf>] ? drm_framebuffer_remove+0x8a/0xfe [drm]
[  121.774739]  [<ffffffffa00101f8>] ? drm_mode_rmfb+0xe1/0x10a [drm]
[  121.774743]  [<ffffffffa00047d4>] ? drm_ioctl+0x344/0x3b3 [drm]
[  121.774747]  [<ffffffffa0010117>] ? drm_mode_addfb+0x79/0x79 [drm]
[  121.774751]  [<ffffffffa00180cc>] ? drm_modeset_drop_locks+0x34/0x3a [drm]
[  121.774752]  [<ffffffff81120714>] ? dput+0x24/0x1aa
[  121.774755]  [<ffffffff8111da12>] ? do_vfs_ioctl+0x360/0x424
[  121.774757]  [<ffffffff810a2634>] ? __audit_syscall_entry+0xb3/0xd3
[  121.774759]  [<ffffffff8100d493>] ? syscall_trace_enter_phase1+0x11a/0x123
[  121.774761]  [<ffffffff8111db1f>] ? SyS_ioctl+0x49/0x7a
[  121.774762]  [<ffffffff81799da9>] ? int_signal+0x12/0x17
[  121.774763]  [<ffffffff81799b72>] ? system_call_fastpath+0x12/0x17
[  121.774764] ---[ end trace e89167dfc4842353 ]---

==Reproduce steps==
---------------------------- 
1. ./kms_rotation_crc --run-subtest sprite-rotation
Comment 1 Jani Nikula 2015-08-18 13:58:00 UTC
Please retest on current drm-intel-nightly.
Comment 2 cprigent 2015-10-13 15:08:51 UTC
This is no test "sprite-rotation" so I launched all of them. There is no Pass:
igt@kms_rotation_crc@bad-pixel-format  Fail 		
igt@kms_rotation_crc@bad-tiling  Fail 		
igt@kms_rotation_crc@cursor-rotation-180  Fail 		
igt@kms_rotation_crc@primary-rotation-180  Fail 		
igt@kms_rotation_crc@primary-rotation-270  Fail 		
igt@kms_rotation_crc@primary-rotation-90  Fail 		
igt@kms_rotation_crc@sprite-rotation-180  Not run 		
igt@kms_rotation_crc@sprite-rotation-270  Not run 		
igt@kms_rotation_crc@sprite-rotation-90  Fail 		
igt@kms_rotation_crc@sprite-rotation-90-pos-100-0  Fail

Hardware:
Platform: SKY LAKE Y A0 
CPU : Intel(R) Core(TM) m5-6Y57 CPU @ 1.10GHz (family: 6, model: 78  stepping: 3)
MCP : SKL-Y  D1 2+2 (ou ULX-D1)
QDF : QJK9 
CPU : SKL D0
Chipset PCH: Sunrise Point LP C1       
CRB : SKY LAKE Y LPDDR3 RVP3 CRB FAB2
Reworks : All Mandatories + FBS02,FBS03, F23, O-02 & O-06
Software
Linux : Ubuntu 14.04 LTS 64 bits
BIOS : SKLSE2R1.R00.X097.B02.1509020030
ME FW : 11.0.0.1173
Ksc (EC FW): 1.19

kernel 4.3.0-rc3-drm-intel-nightly+ (eb69e51) from git://anongit.freedesktop.org/drm-intel
Mesa - 11.0.2 from http://cgit.freedesktop.org/mesa/mesa/
xf86-video-intel - 2.99.917 from http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/
Libdrm - 2.4.64 from http://cgit.freedesktop.org/mesa/drm/
Libva - 1.6.1 from http://cgit.freedesktop.org/libva/
vaapi intel-driver - 1.6.1 from http://cgit.freedesktop.org/vaapi/intel-driver
Cairo - 1.14.2 from http://cgit.freedesktop.org/cairo
Xorg Xserver - 1.17.2 from http://cgit.freedesktop.org/xorg/xserver
Comment 3 Carlos Santa 2016-11-30 00:35:42 UTC
@jani, christophe

this bug can't be reproduced because the test no longer exists as it was reported (bug report is from more than a year ago).

The commit that changed the test is this one:

commit e1ce5eac338f44deda488a44db04faceea12f13a
Author: Sonika Jindal <sonika.jindal@intel.com>
Date:   Wed Apr 22 16:44:05 2015 +0530

    kms_rotation_crc: Adding test for 90/270 rotation
    
    Adding 90/270 rotation testcase for primary and sprite planes.
    
    v2: Added position test for sprite. Checking for gen > 9 for 90/270.
    Some cleanup and rebase.
    v3: Added test for unsupported tiling and unsupported pixel format for 90/270
    v4: Added the legacy commit to initiate modeset in the negative test(Tvrtko)
    
    Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Signed-off-by: Thomas Wood <thomas.wood@intel.com>

However, running the newer tests (sprite-rotation-180, sprite-rotation-270, sprite-rotation-90, sprite-rotation-90-pos-100-0) they all get reported as failures but for a different reason.

We need to close this bug as not invalid and then open new bugs for each of the new test cases that are now failing.

How should we proceed?

Carlos
Comment 4 Carlos Santa 2016-11-30 00:37:10 UTC
(In reply to Carlos Santa from comment #3)
> @jani, christophe
> 
> this bug can't be reproduced because the test no longer exists as it was
> reported (bug report is from more than a year ago).
> 
> The commit that changed the test is this one:
> 
> commit e1ce5eac338f44deda488a44db04faceea12f13a
> Author: Sonika Jindal <sonika.jindal@intel.com>
> Date:   Wed Apr 22 16:44:05 2015 +0530
> 
>     kms_rotation_crc: Adding test for 90/270 rotation
>     
>     Adding 90/270 rotation testcase for primary and sprite planes.
>     
>     v2: Added position test for sprite. Checking for gen > 9 for 90/270.
>     Some cleanup and rebase.
>     v3: Added test for unsupported tiling and unsupported pixel format for
> 90/270
>     v4: Added the legacy commit to initiate modeset in the negative
> test(Tvrtko)
>     
>     Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>     Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>     Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> 
> However, running the newer tests (sprite-rotation-180, sprite-rotation-270,
> sprite-rotation-90, sprite-rotation-90-pos-100-0) they all get reported as
> failures but for a different reason.
> 
> We need to close this bug as not invalid and then open new bugs for each of
> the new test cases that are now failing.
> 
> How should we proceed?
> 
> Carlos

Sorry, above, I meant to say this should be close as invalid...
Comment 5 yann 2016-11-30 09:24:57 UTC
(In reply to Carlos Santa from comment #4)
> (In reply to Carlos Santa from comment #3)
> > @jani, christophe
> > 
> > this bug can't be reproduced because the test no longer exists as it was
> > reported (bug report is from more than a year ago).
> > 
> > The commit that changed the test is this one:
> > 
> > commit e1ce5eac338f44deda488a44db04faceea12f13a
> > Author: Sonika Jindal <sonika.jindal@intel.com>
> > Date:   Wed Apr 22 16:44:05 2015 +0530
> > 
> >     kms_rotation_crc: Adding test for 90/270 rotation
> >     
> >     Adding 90/270 rotation testcase for primary and sprite planes.
> >     
> >     v2: Added position test for sprite. Checking for gen > 9 for 90/270.
> >     Some cleanup and rebase.
> >     v3: Added test for unsupported tiling and unsupported pixel format for
> > 90/270
> >     v4: Added the legacy commit to initiate modeset in the negative
> > test(Tvrtko)
> >     
> >     Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> >     Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >     Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> > 
> > However, running the newer tests (sprite-rotation-180, sprite-rotation-270,
> > sprite-rotation-90, sprite-rotation-90-pos-100-0) they all get reported as
> > failures but for a different reason.
> > 
> > We need to close this bug as not invalid and then open new bugs for each of
> > the new test cases that are now failing.
> > 
> > How should we proceed?
> > 
> > Carlos
> 
> Sorry, above, I meant to say this should be close as invalid...

Agree, closing as invalid

Christophe, please open new bug for current test cases that are failling

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.