Bug 89734

Please attach the dmesg output here directly.

Christian, any ideas?

(In reply to Michel Dänzer from comment #1)
> Please attach the dmesg output here directly.
> 
> Christian, any ideas?

Not of hand. Looks like we don't handle something correctly on tearing this down, but I'm not sure what it is.

Going to take a look at it.

Created attachment 114584 [details] [review]
Debuging patch.

The only possible cause I can come up with is that we try to free the sg table twice.

Please apply the attached debugging patch and report back with the resulting dmesg.

Thanks in advance,
Christian.

Created attachment 114609 [details]
first requested dmesg

Here's the first requested dmesg output.
Applying the attached debugging patch is above my skills, unfortunately.
Don't know if you can create a binary so that I can test (or give me a procedure on how to apply the patch).
Sorry for too low technical skills guys.
The dolphin version tested is 5921 (but same pb on older revisions). Freeze happens on the exit of Mario Kart and Donkey Kong Country Wii (I didn't test more as if seems independant of the game).

(In reply to poub365-bugzilla from comment #4)
> Created attachment 114609 [details]
> first requested dmesg
> 
> Here's the first requested dmesg output.
> Applying the attached debugging patch is above my skills, unfortunately.
> Don't know if you can create a binary so that I can test (or give me a
> procedure on how to apply the patch).
> Sorry for too low technical skills guys.
> The dolphin version tested is 5921 (but same pb on older revisions). Freeze
> happens on the exit of Mario Kart and Donkey Kong Country Wii (I didn't test
> more as if seems independant of the game).

Unfortunately we usually don't have time to provide binary packages for every small patch we make, sorry.

You could try following one of the tutorials on the net how to compile your own kernel with kbuntu. If you managed to do so applying the patch on top of it is trivial.

Created attachment 114670 [details]
dmesg with patch

This is what I did (main commands)
git clone git://kernel.ubuntu.com/ubuntu/ubuntu-vivid.git

patch -p1 </home/jo/internet/Downloads/mesa/0001-WIP-userptr-debuging-patch.patch 

fakeroot debian/rules clean
fakeroot debian/rules binary-headers binary-generic

Installed the new kernel (3.19) and rebooted on it. Same freeze on the exit of Dolphin. Here's the new dmesg log. Hope I did it right.

(In reply to poub365-bugzilla from comment #7)
> Installed the new kernel (3.19) and rebooted on it. Same freeze on the exit
> of Dolphin. Here's the new dmesg log. Hope I did it right.

Yeah, thanks! That's exactly what I needed.

And my initial suspicion was right, for some reason we try to free the SG table twice:

[  141.833287] [drm:radeon_ttm_backend_unbind [radeon]] *ERROR* ttm->sg = ffff880222930e00, ttm->sg->sgl = ffff8802238bd200
...
[  141.898159] [drm:radeon_ttm_backend_unbind [radeon]] *ERROR* ttm->sg = ffff880222930e00, ttm->sg->sgl =           (null)

Which then obviously causes problems.

For a quick fix we could try to double check if we haven't already freed the table, but I think the underlying problem is that we try to free the BO twice as well.

@Michel any ideas?

Created attachment 114727 [details] [review]
Possible fix

Please test the attached patch it should fix your issue for now.

(In reply to Christian König from comment #8)
> @Michel any ideas?

I'm afraid not. :(

Created attachment 114820 [details]
screen flickers with patch

I tried the new patch.
I can exit now without freezing but I have a lot of artifacts (see video) in the game but also on desktop (kde with opengl): the screen flickers a lot.
The dmesg will follow.

Created attachment 114821 [details]
dmesg with patch

No idea if that helps, but just in case.

(In reply to poub365-bugzilla from comment #11)
> I can exit now without freezing but I have a lot of artifacts (see video) in
> the game but also on desktop (kde with opengl): the screen flickers a lot.

Unless setting the environment variable

 MESA_EXTENSION_OVERRIDE='-GL_AMD_pinned_memory'

avoids that problem, it's probably a separate issue that needs to be tracked in its own report, including the corresponding Xorg.0.log file.

Created attachment 114841 [details]
xorg with patch

Created attachment 114842 [details]
dmesg with patch

Very strange: I booted on the patch kernel today to get a Xlog. No flickering on desktop neither on fullscreen game. I didn't upgrade any component since last time. Dolphin is working fine from my quick test.

So, I can now exit dolphin without freezing. I get this message on the console:

The program 'dolphin-emu' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadWindow (invalid Window parameter)'.
  (Details: serial 8835 error_code 3 request_code 38 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
terminate called without an active exception
Abandon (core dumped)

I attach my dmesg and xorg.log just in case.

(In reply to poub365-bugzilla from comment #15)
> Created attachment 114842 [details]
> dmesg with patch
> 
> Very strange: I booted on the patch kernel today to get a Xlog. No
> flickering on desktop neither on fullscreen game. I didn't upgrade any
> component since last time. Dolphin is working fine from my quick test.

Mhm, could be an uninitialized variable or something like this. Not sure off hand. But if it works fine now it's unlikely that this is a driver problem.

> 
> So, I can now exit dolphin without freezing. I get this message on the
> console:
> 
> The program 'dolphin-emu' received an X Window System error.
> This probably reflects a bug in the program.
> The error was 'BadWindow (invalid Window parameter)'.
>   (Details: serial 8835 error_code 3 request_code 38 minor_code 0)
>   (Note to programmers: normally, X errors are reported asynchronously;
>    that is, you will receive the error a while after causing it.
>    To debug your program, run it with the --sync command line
>    option to change this behavior. You can then get a meaningful
>    backtrace from your debugger if you break on the gdk_x_error() function.)
> terminate called without an active exception
> Abandon (core dumped)
> 
> I attach my dmesg and xorg.log just in case.

That's a completely different issue, not even sure if it is a driver problem at all.

(In reply to Christian König from comment #16)
> (In reply to poub365-bugzilla from comment #15)
> > The program 'dolphin-emu' received an X Window System error.
> > This probably reflects a bug in the program.
> > The error was 'BadWindow (invalid Window parameter)'.
> >   (Details: serial 8835 error_code 3 request_code 38 minor_code 0)
> >   (Note to programmers: normally, X errors are reported asynchronously;
> >    that is, you will receive the error a while after causing it.
> >    To debug your program, run it with the --sync command line
> >    option to change this behavior. You can then get a meaningful
> >    backtrace from your debugger if you break on the gdk_x_error() function.)
> > terminate called without an active exception
> > Abandon (core dumped)
> > 
> > I attach my dmesg and xorg.log just in case.
> 
> That's a completely different issue, not even sure if it is a driver problem
> at all.

It's not - request #38 is XQueryPointer, which GL drivers don't do.

In this case we can probably close this bug report, cause the original issue is fixed.

If you find another issue which could be cause by the driver stack feel free to open up a new bug.

Thanks for the help,
Christian.