Bug 89750

Summary:	Missing line continuation in definition of MAYBE_WARN in configure
Product:	cairo	Reporter:	Larry Baker <baker>
Component:	general	Assignee:	Chris Wilson <chris>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	minor
Priority:	medium
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Mac OS X (All)
Whiteboard:
i915 platform:		i915 features:

Description Larry Baker 2015-03-24 22:35:09 UTC

There is an unintentional (benign) missing line continuation "\" in the definition of MAYBE_WARN in configure.  configure completes and issues a WARNING:

configure: WARNING: cache variable cairo_cv_warn_maybe contains a newline

The error is at line 18461 in configure (release 1.14.2):

$ grep -w -n '[-]Wpacked' configure
18461:-Wpointer-arith -Wwrite-strings -Wsign-compare -Wpacked

I fixed it with sed:

$ sed -i -e '/^MAYBE_WARN=/,/^MAYBE_C_SPECIFIC_WARN=/s/-Wpacked$/-Wpacked \\/' configure

$ grep -w -n '[-]Wpacked' configure
18461:-Wpointer-arith -Wwrite-strings -Wsign-compare -Wpacked \

Comment 1 Bryce Harrington 2015-06-27 07:46:13 UTC

Thanks, good find.  The fix actually needs to go into build/configure.ac.warnings

commit 776dd20c8485e4e70f42a2e66a0545cf87944ac5
Author: Bryce Harrington <bryce@osg.samsung.com>
Date:   Sat Jun 27 00:43:04 2015 -0700

    configure: Fix typo for missing line continuation character

    There is an unintentional (benign) missing line continuation "\" in the
    definition of MAYBE_WARN in configure.  configure completes and issues a
    WARNING:

    configure: WARNING: cache variable cairo_cv_warn_maybe contains a
    newline

    Found and solved by Larry Baker.

    Fixes:  https://bugs.freedesktop.org/show_bug.cgi?id=89750
    Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.