| Summary: | [ All bisected] igt/kms_fbc_crc cases fail | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | ye.tian <yex.tian> | ||||||
| Component: | DRM/Intel | Assignee: | Thomas Wood <thomas.wood> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||
| Severity: | normal | ||||||||
| Priority: | medium | CC: | intel-gfx-bugs | ||||||
| Version: | unspecified | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
ye.tian
2015-03-31 08:06:19 UTC
./kms_vblank --run-subtest query-busy also fail. The same one igt commit(47f6b130). Created attachment 114826 [details] [review] tests/kms_fbc_crc: fix fread() return value assertion Please test that the attached patch fixes the issue with kms_fbc_crc. The issue with kms_vblank should be fixed by the following commit: commit 590e47c94fd81a182e24b41a715d84491df8cea8 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Thu Apr 2 11:37:23 2015 +0100 igt/kms_vblank: Include a test for comparing blocking drmWaitVblank (In reply to Thomas Wood from comment #2) > Created attachment 114826 [details] [review] [review] > tests/kms_fbc_crc: fix fread() return value assertion > > Please test that the attached patch fixes the issue with kms_fbc_crc. > > > The issue with kms_vblank should be fixed by the following commit: > > commit 590e47c94fd81a182e24b41a715d84491df8cea8 > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Thu Apr 2 11:37:23 2015 +0100 > > igt/kms_vblank: Include a test for comparing blocking drmWaitVblank Hi Thomas, don't forget changing the bug status to NEEDINFO/RESOLVED any time you need further information from QA or the bug can be fixed probably. That can protect QA from escaping the bug updating. Thanks. :p (In reply to Thomas Wood from comment #2) > Created attachment 114826 [details] [review] [review] > tests/kms_fbc_crc: fix fread() return value assertion > > Please test that the attached patch fixes the issue with kms_fbc_crc. Tested it on igt(e8457ed) with this patch on BDW and IVB,this issue still exists. output: -------------- root@x-bdw01:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_fbc_crc IGT-Version: 1.10-g4f2d6f7 (x86_64) (Linux: 4.0.0-rc6_drm-intel-nightly_333cf6_20150403+ x86_64) Test requirement not met in function __real_main493, file kms_fbc_crc.c:519: Test requirement: !strstr(buf, "unsupported by this chipset") && !strstr(buf, "disabled per module param") && !strstr(buf, "disabled per chip default") FBC not supported/enabled Subtest page_flip: SKIP Subtest mmap_cpu: SKIP Subtest mmap_gtt: SKIP Subtest blt: SKIP Subtest render: SKIP Subtest context: SKIP Subtest page_flip_and_mmap_cpu: SKIP Subtest page_flip_and_mmap_gtt: SKIP Subtest page_flip_and_blt: SKIP Subtest page_flip_and_render: SKIP Subtest page_flip_and_context: SKIP > The issue with kms_vblank should be fixed by the following commit: > > commit 590e47c94fd81a182e24b41a715d84491df8cea8 > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Thu Apr 2 11:37:23 2015 +0100 > > igt/kms_vblank: Include a test for comparing blocking drmWaitVblank Tested it on igt (e8457edb) and the latest nightly kernel, kms_vblank case is good. (In reply to ye.tian from comment #4) > (In reply to Thomas Wood from comment #2) > > Created attachment 114826 [details] [review] [review] [review] > > tests/kms_fbc_crc: fix fread() return value assertion > > > > Please test that the attached patch fixes the issue with kms_fbc_crc. > > Tested it on igt(e8457ed) with this patch on BDW and IVB,this issue still > exists. > The results show the tests now skip rather than fail. Please compare with the original status of the tests before the regression. (In reply to Thomas Wood from comment #5) > (In reply to ye.tian from comment #4) > > (In reply to Thomas Wood from comment #2) > > > Created attachment 114826 [details] [review] [review] [review] [review] > > > tests/kms_fbc_crc: fix fread() return value assertion > > > > > > Please test that the attached patch fixes the issue with kms_fbc_crc. > > > > Tested it on igt(e8457ed) with this patch on BDW and IVB,this issue still > > exists. > > > > The results show the tests now skip rather than fail. Please compare with > the original status of the tests before the regression. The output status is the same. output: [root@x-ivb6 tests]# ./kms_fbc_crc IGT-Version: 1.10-g0c4dd28 (x86_64) (Linux: 4.0.0-rc6_drm-intel-fixes_840a1c_20150403_debug+x86_64) Test requirement not met in function __real_main493, file kms_fbc_crc.c:519: Test requirement: !strstr(buf, "unsupported by this chipset") && !strstr(buf, "disabled per module param") && !strstr(buf, "disabled per chip default") FBC not supported/enabled Subtest page_flip: SKIP Subtest mmap_cpu: SKIP Subtest mmap_gtt: SKIP Subtest blt: SKIP Subtest render: SKIP Subtest context: SKIP Subtest page_flip_and_mmap_cpu: SKIP Subtest page_flip_and_mmap_gtt: SKIP Subtest page_flip_and_blt: SKIP Subtest page_flip_and_render: SKIP Subtest page_flip_and_context: SKIP Patch pushed as commit 564dfd4. Tested it on the below the igt patch, this issue does not exists on all platform. root@x-bsw03:~# cat /sys/kernel/debug/dri/0/i915_fbc_status FBC unsupported on this chipset diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index ccdec33..1320bad 100644 --- a/tests/kms_fbc_crc.c +++ b/tests/kms_fbc_crc.c @@ -513,7 +513,7 @@ igt_main igt_assert_lt(0, fread(buf, 1, sizeof(buf), status)); fclose(status); buf[sizeof(buf) - 1] = '\0'; - igt_require_f(!strstr(buf, "unsupported by this chipset") && + igt_require_f(!strstr(buf, "unsupported on this chipset") && !strstr(buf, "disabled per module param") && !strstr(buf, "disabled per chip default"), "FBC not supported/enabled\n"); Closing old verified. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.