| Summary: | [i965 Bisected NIR] Piglit/gglean_fragprog1-z-write_test fail | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Kenneth Graunke <kenneth> |
| Status: | VERIFIED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | major | ||
| Priority: | highest | ||
| Version: | git | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
lu hua
2015-04-13 02:19:58 UTC
Please file a separate bug for the ES3 conformance problem if necessary. It is a separate bug. (In reply to Kenneth Graunke from comment #1) > Patch on list: > http://lists.freedesktop.org/archives/mesa-dev/2015-April/082137.html Piglit case fixed by this patch, ogles3conform case still fail. report bug 90114. commit 44461e70985278464f5c2ce89bda2336c7299b0b Author: Kenneth Graunke <kenneth@whitecape.org> Date: Fri Apr 17 14:08:14 2015 -0700 nir: Fix per-component negation in prog_to_nir's SWZ handling. glean_fragprog1-swz_test works well.
glean_fragprog1-z-write_test and glean_fragprog1-rsq_test_2_(reciprocal_square_root_of_negative_value) still fail.
libGL: OpenDriver: trying /opt/X11R7/lib/dri/tls/i965_dri.so
libGL: OpenDriver: trying /opt/X11R7/lib/dri/i965_dri.so
----------------------------------------------------------------------
Fragment Program test 1: test a specific set of fragment programs.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, db, z24, s8, win+pmap, id 32
0 tests passed, 1 tests failed.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, db, z24, s8, win+pmap, id 33
0 tests passed, 1 tests failed.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, db, z24, s8, win+pmap, id 111
0 tests passed, 1 tests failed.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, z24, s8, win+pmap, id 158
0 tests passed, 1 tests failed.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, db, z24, s8, accrgba16, win+pmap, slow, id 159
0 tests passed, 1 tests failed.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, z24, s8, win+pmap, id 166
0 tests passed, 1 tests failed.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, db, z24, s8, win+pmap, id 167
0 tests passed, 1 tests failed.
FAILURE:
Program: Z-write test
Expected color: 0.5, 0.25, 1, 0.5
Observed color: 0, 0, 0, 0
fragProg1: FAIL rgba8, db, z24, s8, accrgba16, win+pmap, slow, id 168
0 tests passed, 1 tests failed.
We're losing, what is presumably, our depth write:
pass -> fail
mov(8) g123<1>F g2<0,1,0>F
mov(8) g124<1>F g2.1<0,1,0>F
mov(8) g125<1>F g2.2<0,1,0>F
mov(8) g126<1>F g2.3<0,1,0>F
-mov(8) g127<1>F g2.1<0,1,0>F
sendc(8) null g123<8,8,1>F
render RT write SIMD8 LastRT Surface = 0 mlen 5 rlen 0
The mlen is still correct, so we're writing uninitialized values.
Checking out commit 1ca60de4c (before we deleted the non-NIR paths), you can run with INTEL_USE_NIR=0 and the test passes.
Fix on the mailing list: http://lists.freedesktop.org/archives/mesa-dev/2015-June/085809.html Fixed on master by: commit 7b8f20ec5505a25958bcd98aabe73a7ca2b6cbba Author: Kenneth Graunke <kenneth@whitecape.org> Date: Thu Jun 4 17:00:17 2015 -0700 prog_to_nir: Fix fragment depth writes. In the ARB_fragment_program specification, the result.depth output variable is treated as a vec4, where the fragment depth is stored in the .z component, and the other three components are undefined. This is different than GLSL, which uses a scalar value (gl_FragDepth). To make this consistent for driver backends, this patch makes prog_to_nir use a scalar output variable for FRAG_RESULT_DEPTH, moving result.depth.z into the first component. Fixes Glean's fragProg1 "Z-write test" subtest. Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90000 Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Matt Turner <mattst88@gmail.com> does this bug impact 10.6? Yes, but I've Cc'd mesa-stable, so Emil will pick it up. Verified.Fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.