| Summary: | SIGBUS in polygon_add_edge on sparc | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Peter Spiess-Knafl <psk> |
| Component: | png functions | Assignee: | Carl Worth <cworth> |
| Status: | RESOLVED FIXED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | normal | ||
| Priority: | high | ||
| Version: | unspecified | ||
| Hardware: | SPARC | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Peter Spiess-Knafl
2015-04-19 12:34:38 UTC
Could you check if commit 40201f4b1ab52c85922b2b7ae05dd862159a1aa0 fixes your issue? commit 40201f4b1ab52c85922b2b7ae05dd862159a1aa0 Author: Uli Schlachter <psychon@znc.in> Date: Fri Dec 5 14:43:26 2014 +0100 tor-scan-converter: Correctly align 64bit types On 32bit SPARC the scan converter was causing a SIGBUS due to an unaligned memory access while accessing an int64_t. This memory accessing was to struct quorem's rem member. This crash occurred because the tor-scan-converter contains its own implementation of a memory pool. This implementation only guarantees an alignment of sizeof(void *), which is less than what a 64 bit type requires on 32bit platforms. This 4 byte alignment is guaranteed, because struct _pool_chunk (which is the struct that is used for managing free space) contains elements of that size and so the size of that struct is a multiple of this size as well. This problem was introduced with commit 03c3d4b7c15. To fix this problem, this commit introduces a int64_t member to struct _pool_chunk that marks the beginning of the free data space. Thanks to this, the compiler ensures proper alignment and sizeof(struct _pool_chunk) becomes a multiple of 8. However, previously the end of the struct marked the beginning of the data and sizeof() was used for correctly calculating offsets to the data section. So, just adding such a member would work, but would also waste some memory. To avoid this, this commit also changes the rest of the pool implementation to accommodate. Reported-by: Nicolas Setton <setton@adacore.com> Signed-off-by: Uli Schlachter <psychon@znc.in> Reviewed-by: Bryce Harrington <bryce@osg.samsung.com> It worked. Thank you. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.