Bug 90256

Summary: Increase drag timeout
Product: Wayland Reporter: Velimir Lisec <lisec.velimir>
Component: libinputAssignee: Wayland bug list <wayland-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: peter.hutterer
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch that increases drag timeout to 300 ms.

Description Velimir Lisec 2015-04-30 10:58:24 UTC
Created attachment 115473 [details]
Patch that increases drag timeout to 300 ms.

Currently drag timeout is set to DEFAULT_TAP_TIMEOUT. That is too short. I'm attaching a patch with DEFAULT_DRAG_TIMEOUT set to 300 ms.
Comment 1 Peter Hutterer 2015-05-01 06:43:58 UTC
can I assume your signed-off-by for this patch? looks good otherwise, though I'll add a bit to the commit message to explain that this needs to accommodate for the finger movement during dragging.
Comment 2 Velimir Lisec 2015-05-01 06:56:06 UTC
(In reply to Peter Hutterer from comment #1)
> can I assume your signed-off-by for this patch?

yes, of course.
Comment 3 Peter Hutterer 2015-05-01 07:05:34 UTC
hmm, I reckon 300 may be a bit on the low side, testing here on a T440 with a fairly big touchpad I lose it quite often. you said in the other bug report you had 700ms for synaptics, how about something in the middle: 500? that seems reliable here though it feels slow on the release but there isn't much we can do I think, at least not without Bug 90255
Comment 4 Velimir Lisec 2015-05-01 07:25:17 UTC
(In reply to Peter Hutterer from comment #3)
> hmm, I reckon 300 may be a bit on the low side, testing here on a T440 with
> a fairly big touchpad I lose it quite often. you said in the other bug
> report you had 700ms for synaptics, how about something in the middle: 500?
> that seems reliable here though it feels slow on the release but there isn't
> much we can do I think, at least not without Bug 90255

Ah, yes. I don't have that big of a touchpad so smaller timeout works for me. Set it to 500 if that works good for you. Ideally, that timeout should be configurable by the user.
Comment 6 Peter Hutterer 2015-05-04 06:18:18 UTC
pushed as commit ff132b2cfbb6edb407f80c4bd238dc75eb97c7f1, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.