Bug 90353

Summary:	SYSTEM76_CLEVO model should be CLEVO_W740SU
Product:	Wayland	Reporter:	Jan Alexander Steffens (heftig) <jan.steffens>
Component:	libinput	Assignee:	Wayland bug list <wayland-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	peter.hutterer
Version:	1.5.0
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	[PATCH] Rename MODEL_SYSTEM76_CLEVO to MODEL_CLEVO_W740SU

Description Jan Alexander Steffens (heftig) 2015-05-06 22:01:15 UTC

Bug 90170 added the EVDEV/LIBINPUT_MODEL_SYSTEM76_CLEVO identifier. The hardware matched by this hwdb entry should be any W740SU manufactured by Clevo (http://www.clevo.com.tw/clevo_prodetail.asp?id=639&lang=en).

The W740SU rebrand I have here (Schenker S413) keeps the original DMI strings, while the System76 Galago Ultra Pro firmware changes the strings.

So these identifiers should probably be named EVDEV/LIBINPUT_MODEL_CLEVO_W740SU.

Comment 1 Peter Hutterer 2015-05-07 04:44:09 UTC

hmm, this now brings up the question: is the W740SU alway set up to support clickfinger by default? if not, is there a way to differentiate the system76 model (which apparently is set up this way)?

Comment 2 Jan Alexander Steffens (heftig) 2015-05-07 12:54:37 UTC

I'm not sure what you mean. The System76 model and the Schenker model are visually identical to the Clevo model, with the exception of branding on the back of the screen. None have any markings on the touchpad.

Comment 3 Peter Hutterer 2015-05-18 09:32:38 UTC

rightyo, can you send me a patch to change the entry then, with the appropriate comments. thanks.

Comment 4 Jan Alexander Steffens (heftig) 2015-05-18 13:29:38 UTC

Created attachment 115883 [details] [review]
[PATCH] Rename MODEL_SYSTEM76_CLEVO to MODEL_CLEVO_W740SU

The System76 Galago Ultra Pro is a rebranded Clevo W740SU with changed
firmware strings. To my knowledge, the Clevo W740SU and all its rebrands
possess smooth touchpads.

In the original bug report[1], a Galago Ultra Pro was returned to the
original DMI strings by flashing another firmware. This resulted in the
model identified as MODEL_SYSTEM76_CLEVO.

Since the actual manufacturer of the W740SU is Clevo and the CLEVO hwdb
entry already properly identifies other W740SU rebrands like the Schenker
S413, the model should be renamed to match.

[1]: https://bugs.freedesktop.org/show_bug.cgi?id=90170#c3

https://bugs.freedesktop.org/show_bug.cgi?id=90353

Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>

Comment 5 Peter Hutterer 2015-05-21 01:47:29 UTC

Pushed as e39dca063bb27546c52970ba4a83d28d05563893, thanks.

Just for the archives, based on the original Bug 90170, I was under the assumption that all System76 laptops defaulted to clickfinger behaviour. This one is for a different model that may not have that default (even though the touchpad seems to be designed that way). Having a single Clevo laptop default to a different behaviour is not ideal but it's also IMO not worth worrying about.

Long-term, if this causes issue with other clevo-branded models we may have to revert this one altogether.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.