Bug 90446

Summary: [BDW Bisected]igt/pm_rpm and kms_flip causes WARNING: CPU: 0 PID: 4951 at drivers/gpu/drm/i915/intel_display.c:1357 hsw_disable_ips+0x34/0x162
Product: DRI Reporter: lu hua <huax.lu>
Component: DRM/IntelAssignee: Maarten Lankhorst <bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: high CC: intel-gfx-bugs
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg none

Description lu hua 2015-05-14 07:57:33 UTC 
Created attachment 115762 [details]
dmesg

==System Environment==
--------------------------
Regression: yes

good commit: dcdaab3ad1518eaf1ce31fd56d010c69a0754e06
bad commit:  65de797816eadb227c45b0127d7ff92410fa3814

Non-working platforms: BDW

==kernel==
--------------------------
drm-intel-nightly/6cf0fff478fa64991c2b7f2a44f2815d7a43a0b5
commit 6cf0fff478fa64991c2b7f2a44f2815d7a43a0b5
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed May 13 11:29:25 2015 +0200

    drm-intel-nightly: 2015y-05m-13d-09h-28m-49s UTC integration manifest

==Bug detailed description==
-----------------------------
It causes warning on drm-intel-nightly and drm-intel-next-queued kernel. WARNING: CPU: 0 PID: 4951 at drivers/gpu/drm/i915/intel_display.c:1357 hsw_disable_ips+0x34/0x162 [i915]()

IGT-Version: 1.10-g9b0a32d (x86_64) (Linux: 4.1.0-rc3_drm-intel-nightly_6cf0ff_20150514+ x86_64)
Runtime PM support: 1
PC8 residency support: 1
Subtest dpms-lpsp: SUCCESS (1.126s)

[   35.555749] ------------[ cut here ]------------
[   35.555784] WARNING: CPU: 0 PID: 4951 at drivers/gpu/drm/i915/intel_display.c:1357 hsw_disable_ips+0x34/0x162 [i915]()
[   35.555787] plane A assertion failure (expected on, current off)
[   35.555789] Modules linked in: ipv6 dm_mod iTCO_wdt iTCO_vendor_support ppdev snd_hda_codec_hdmi snd_hda_intel snd_hda_codec pcspkr snd_hda_core snd_hwdep i2c_i801 snd_pcm lpc_ich snd_timer mfd_core snd soundcore battery parport_pc parport ac acpi_cpufreq i915 button video drm_kms_helper drm
[   35.555814] CPU: 0 PID: 4951 Comm: pm_rpm Tainted: G        W       4.1.0-rc3_drm-intel-nightly_6cf0ff_20150514+ #230
[   35.555817]  0000000000000000 0000000000000009 ffffffff817a67ac ffff8800a29c7b78
[   35.555822]  ffffffff8103ebde ffff880144447c00 ffffffffa00d4e89 0000000000000000
[   35.555826]  ffff880002c70000 ffff88014953a000 ffff8800a7ebe000 0000000000000000
[   35.555830] Call Trace:
[   35.555838]  [<ffffffff817a67ac>] ? dump_stack+0x40/0x50
[   35.555842]  [<ffffffff8103ebde>] ? warn_slowpath_common+0x98/0xb0
[   35.555864]  [<ffffffffa00d4e89>] ? hsw_disable_ips+0x34/0x162 [i915]
[   35.555868]  [<ffffffff8103ec3b>] ? warn_slowpath_fmt+0x45/0x4a
[   35.555888]  [<ffffffffa00d4e89>] ? hsw_disable_ips+0x34/0x162 [i915]
[   35.555908]  [<ffffffffa00d5051>] ? intel_crtc_disable_planes+0x22/0xce [i915]
[   35.555927]  [<ffffffffa00d5a1e>] ? __intel_set_mode+0x41c/0x94d [i915]
[   35.555948]  [<ffffffffa00db225>] ? intel_crtc_set_config+0x3f2/0x53d [i915]
[   35.555964]  [<ffffffffa000c326>] ? drm_mode_set_config_internal+0x4e/0xd2 [drm]
[   35.555978]  [<ffffffffa0010185>] ? drm_mode_setcrtc+0x3fe/0x4f4 [drm]
[   35.555989]  [<ffffffffa0004636>] ? drm_ioctl+0x322/0x38d [drm]
[   35.555993]  [<ffffffff8116e640>] ? kernfs_seq_start+0x24/0x7a
[   35.556005]  [<ffffffffa000fd87>] ? drm_mode_setplane+0x178/0x178 [drm]
[   35.556010]  [<ffffffff81123546>] ? do_vfs_ioctl+0x360/0x424
[   35.556015]  [<ffffffff81114c30>] ? vfs_read+0xd2/0x110
[   35.556018]  [<ffffffff81123653>] ? SyS_ioctl+0x49/0x7a
[   35.556022]  [<ffffffff817ac317>] ? system_call_fastpath+0x12/0x6a
[   35.556026] ---[ end trace e5520cc839db9848 ]---
[   35.556031] ------------[ cut here ]------------

==Reproduce steps==
---------------------------- 
1.  ./pm_rpm --run-subtest dpms-lpsp
Comment 1 lu hua 2015-05-14 08:05:42 UTC 
some kms_flip and pm_rpm subcase have this warning.
Run  ./kms_flip --run-subtest blt-flip-vs-dpms, it also has this warning.
IGT-Version: 1.10-g9b0a32d (x86_64) (Linux: 4.1.0-rc3_drm-intel-nightly_6cf0ff_20150514+ x86_64)
Using monotonic timestamps
Beginning blt-flip-vs-dpms on crtc 20, connector 31
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
...........
blt-flip-vs-dpms on crtc 20, connector 31: PASSED

Beginning blt-flip-vs-dpms on crtc 24, connector 31
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
............
blt-flip-vs-dpms on crtc 24, connector 31: PASSED

Beginning blt-flip-vs-dpms on crtc 28, connector 31
  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
............
blt-flip-vs-dpms on crtc 28, connector 31: PASSED

Subtest blt-flip-vs-dpms: SUCCESS (62.521s)
Comment 2 Ander Conselvan de Oliveira 2015-05-15 12:36:31 UTC 
(In reply to lu hua from comment #0)
> Regression: yes

Please bisect.
Comment 3 lu hua 2015-05-18 09:02:19 UTC 
ce22dba92de22e951dee2ff89937a39754d2dd91 is the first bad commit.
commit ce22dba92de22e951dee2ff89937a39754d2dd91
Author:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
AuthorDate: Tue Apr 21 17:12:56 2015 +0300
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Fri May 8 13:03:56 2015 +0200

    drm/i915: Move toggling planes out of crtc enable/disable.

    This makes disabling planes more explicit.

    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    [anderco: fixed warning due to using drm_crtc instead of intel_crtc]
    Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@inte
    Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Comment 4 Maarten Lankhorst 2015-05-18 14:47:34 UTC 
Is that really the first commit with the error?

I would expect some other commit from that series.
Comment 5 Ander Conselvan de Oliveira 2015-05-19 07:25:08 UTC 
Does the warning occur on every run of the test?
Comment 6 ye.tian 2015-05-19 09:21:31 UTC 
(In reply to Ander Conselvan de Oliveira from comment #5)
> Does the warning occur on every run of the test?

Yes.
Comment 7 Maarten Lankhorst 2015-06-07 15:57:51 UTC 
Is this still an issue with latest drm-intel-nightly?
Comment 8 lu hua 2015-06-08 02:04:11 UTC 
Test on the latest drm-intel-nightly kernel, this warning goes away.
Comment 9 lu hua 2015-06-08 02:04:36 UTC 
Verified.Fixed.
Comment 10 Elizabeth 2017-10-06 14:29:56 UTC 
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.