Bug 9046

Summary: Calling _mesa_compressed_image_address with invalid parameter in texcompress_fxt1.c triggers a Mesa internal error
Product: Mesa Reporter: haihao <haihao.xiang>
Component: Mesa coreAssignee: mesa-dev
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: high    
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch to fix this bug

Description haihao 2006-11-15 18:24:50 UTC
In functions texstore_rgba_fxt1 and texstore_rgb_fxt1(texcompress_fxt1.c), calling 
_mesa_compressed_image_address with mesaFormat set to
GL_COMPRESSED_RGB_FXT1_3DFX or GL_COMPRESSED_RGBA_FXT1_3DFX. From the context,
it is a mistake. Here it should pass a Mesa internal format, or it will trigger
a mesa error.

    107    dst = _mesa_compressed_image_address(dstXoffset, dstYoffset, 0,
    108                                         GL_COMPRESSED_RGB_FXT1_3DFX,
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    109                                         texWidth, (GLubyte *) dstAddr);
Comment 1 haihao 2006-11-15 18:28:02 UTC
Created attachment 7805 [details] [review]
Patch to fix this bug
Comment 2 Brian Paul 2006-11-16 07:36:39 UTC
Fixed.  Thanks.
Comment 3 haihao 2006-11-16 18:27:18 UTC
verified
Comment 4 Adam Jackson 2009-08-24 12:24:58 UTC
Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.