Bug 90773

Summary: make sure we use the correct win32 socket errno codes
Product: PulseAudio Reporter: Pierre Ossman <pierre-bugzilla>
Component: coreAssignee: pulseaudio-bugs
Status: RESOLVED FIXED QA Contact: pulseaudio-bugs
Severity: normal    
Priority: medium CC: lennart
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: patch that fixes all errno defines

Description Pierre Ossman 2015-05-29 14:46:14 UTC
Created attachment 116152 [details]
patch that fixes all errno defines

Visual Studio (and now mingw) provide some rather evil errno defines that are never used by any Windows API. It breaks constructs such as:

#ifndef ECONNREFUSED
#define ECONNREFUSED WSAECONNREFUSED
#endif

Fortunately PulseAudio had a rather unconditional approach to handling winsock defines. Still, this can cause compiler complaints and not all errno:s were properly redefined.

The attached patch does a more complete coverage of things.
Comment 1 Tanu Kaskinen 2015-05-30 10:21:53 UTC
Thanks! Applied. I also added winerrno.h to Makefile.am.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.