Bug 90778

Summary:	udisks-1.0.5: build failure with glibc 2.20: storage size of ‘statbuf’ isn’t known
Product:	udisks	Reporter:	Alexandre Rostovtsev <tetromino>
Component:	general	Assignee:	Martin Pitt <martin.pitt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	amigadave, freedesktop-bugs
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	trivial patch

Description Alexandre Rostovtsev 2015-05-30 01:09:14 UTC

Reported downstream at https://bugs.gentoo.org/show_bug.cgi?id=550758

When attempting to build old udisks-1.0.5 on a glibc-2.20 system:


job-drive-detach.c: In function ‘sysfs_exists’:
job-drive-detach.c:44:15: error: storage size of ‘statbuf’ isn’t known
   struct stat statbuf;
               ^
job-drive-detach.c:51:7: warning: implicit declaration of function ‘stat’ [-Wimplicit-function-declaration]
   if (stat (s, &statbuf) == 0)
       ^
job-drive-detach.c:51:3: warning: nested extern declaration of ‘stat’ [-Wnested-externs]
   if (stat (s, &statbuf) == 0)
   ^
job-drive-detach.c:44:15: warning: unused variable ‘statbuf’ [-Wunused-variable]
   struct stat statbuf;
               ^
job-drive-detach.c: In function ‘main’:
job-drive-detach.c:110:15: error: storage size of ‘statbuf’ isn’t known
   struct stat statbuf;
               ^
job-drive-detach.c:110:15: warning: unused variable ‘statbuf’ [-Wunused-variable]
Makefile:901: recipe for target 'udisks_helper_drive_detach-job-drive-detach.o' failed

Comment 1 Alexandre Rostovtsev 2015-05-30 01:12:02 UTC

Created attachment 116163 [details] [review]
trivial patch

Comment 2 Martin Pitt 2015-06-11 20:59:37 UTC

Thanks! I applied this to the old udisks1 branch, but please note that I won't make a new release. udisks 1.x has been deprecated for years already.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.