| Summary: | [BDW Bisected]igt/gem_ctx_param_basic/invalid-param-get fails | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | lu hua <huax.lu> | ||||||||
| Component: | DRM/Intel | Assignee: | David Weinehall <david.weinehall> | ||||||||
| Status: | CLOSED WORKSFORME | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | high | CC: | christophe.prigent, intel-gfx-bugs | ||||||||
| Version: | unspecified | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux (All) | ||||||||||
| Whiteboard: | |||||||||||
| i915 platform: | BDW | i915 features: | GEM/Other | ||||||||
| Attachments: |
|
||||||||||
|
Description
lu hua
2015-06-02 03:07:02 UTC
Please bisect. commit f86cc198b4f9a631f96167219cb8460ce517ca0a Author: David Weinehall <david.weinehall@linux.intel.com> Date: Wed May 20 17:00:13 2015 +0300 drm/i915: add a context parameter to {en, dis}able zero address mapping Just igt's negative testing requires updating. (In reply to Chris Wilson from comment #2) > commit f86cc198b4f9a631f96167219cb8460ce517ca0a > Author: David Weinehall <david.weinehall@linux.intel.com> > Date: Wed May 20 17:00:13 2015 +0300 > > drm/i915: add a context parameter to {en, dis}able zero address mapping > > > Just igt's negative testing requires updating. I confirmed this commit is the first bad commit. commit b1b38278e12b04cf9a227f6af2c24651cf6e8a85 Author: David Weinehall <david.weinehall@linux.intel.com> AuthorDate: Wed May 20 17:00:13 2015 +0300 Commit: Daniel Vetter <daniel.vetter@ffwll.ch> CommitDate: Fri May 29 10:15:19 2015 +0200 drm/i915: add a context parameter to {en, dis}able zero address mapping Export a new context parameter that can be set/queried through the context_{get,set}param ioctls. This parameter is passed as a context flag and decides whether or not a GPU address mapping is allowed to be made at address zero. The default is to allow such mappings. Signed-off-by: David Weinehall <david.weinehall@intel.com> Acked-by: "Zou, Nanhai" <nanhai.zou@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Fixed in igt: commit 0b45b0746f45deea11670a8b2c949776bbbef55c Author: Jesse Barnes <jbarnes@virtuousgeek.org> Date: Thu Aug 6 13:12:46 2015 -0700 tests/gem_ctx_param_basic: fix invalid params Use -1 as the invalid param since we've added more since this test was created, causing expected EINVAL failures to return an unexpected error code. Re-opening and assigning to David. Created attachment 117577 [details] [review] Improved tests for context parameters @Jesse: What about the fix in commit 0b45b0746f45deea11670a8b2c949776bbbef55c you refer to? Have you reverted that one, or did you never push it? Anyway, I have a version of this test that includes tests for no-zeromap too, it's been sitting on my system for quite a while. I don't remember why I haven't submitted it to intel-gfx; possibly because the flux around the no-zeromap patch itself. I've attached the patch here, I'll submit it to intel-gfx too. Created attachment 117603 [details] [review] Updated version of the patch. The test is working without issues, following configuration: --- Software information --- ++ Kernel version : 4.4.4-040404-generic ++ Linux distribution : Ubuntu 15.10 ++ Architecture : 64-bit ++ xf86-video-intel version : 2.99.917 ++ Xorg-Xserver version : 1.17.2 ++ DRM version : 2.4.64 ++ VAAPI version : Intel i965 driver for Intel(R) Broadwell - 1.6.0 ++ Cairo version : 1.14.2 ++ Intel GPU Tools version : Tag [intel-gpu-tools-1.14-74-g431f6c4] / Commit [431f6c4] ++ Kernel driver in use : i915 ++ Bios revision : 5.6 --- Hardware information --- ++ Platform : ++ Motherboard model : ++ Motherboard type : NUC5i7RYB Desktop ++ Motherboard manufacturer : ++ CPU family : Core i7 ++ CPU information : Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz ++ GPU Card : Intel Corporation Broadwell-U Integrated Graphics (rev 09) (prog-if 00 [VGA controller]) ++ Memory ram : 8 GB ++ Maximum memory ram allowed : 16 GB ++ Display resolution : ++ CPU's number : 4 ++ Hard drive capacity : 120 GB Output: ./gem_ctx_param_basic --run-subtest invalid-param-get IGT-Version: 1.14-g431f6c4 (x86_64) (Linux: 4.4.4-040404-generic x86_64) Subtest invalid-param-get: SUCCESS (0.000s) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.